Skip to content

Conversation

@kai-zeng
Copy link

Add contains(key) to org.apache.spark.sql.catalyst.util.Metadata to test the existence of a key. Otherwise, Class Metadata's get methods may throw NoSuchElement exception if the key does not exist.
Testcases are added to MetadataSuite as well.

@SparkQA
Copy link

SparkQA commented Nov 14, 2014

Test build #23394 has started for PR 3273 at commit 74b3d03.

  • This patch merges cleanly.

@marmbrus
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23394 timed out for PR 3273 at commit 74b3d03 after a configured wait of 120m.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23394/
Test FAILed.

@rxin
Copy link
Contributor

rxin commented Nov 15, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23414 has started for PR 3273 at commit 74b3d03.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23414 has finished for PR 3273 at commit 74b3d03.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23414/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Nov 15, 2014

Merging in master & branch-1.2. Thanks!

asfgit pushed a commit that referenced this pull request Nov 15, 2014
Add contains(key) to org.apache.spark.sql.catalyst.util.Metadata to test the existence of a key. Otherwise, Class Metadata's get methods may throw NoSuchElement exception if the key does not exist.
Testcases are added to MetadataSuite as well.

Author: kai <[email protected]>

Closes #3273 from kai-zeng/metadata-fix and squashes the following commits:

74b3d03 [kai] Added contains(key) to Metadata

(cherry picked from commit cbddac2)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in cbddac2 Nov 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants