Skip to content

[SPARK-4425][SQL] Handle NaN or Infinity cast to Timestamp correctly. #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ueshin wants to merge 1 commit into from
Closed

[SPARK-4425][SQL] Handle NaN or Infinity cast to Timestamp correctly. #3283

ueshin wants to merge 1 commit into from

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Nov 15, 2014

Cast from NaN or Infinity of Double or Float to TimestampType throws NumberFormatException.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23422 has started for PR 3283 at commit 14def0c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23422 has finished for PR 3283 at commit 14def0c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 15, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23422/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented Nov 18, 2014

Thanks! Merged to master and 1.2

@asfgit asfgit closed this in 566c791 Nov 18, 2014
asfgit pushed a commit that referenced this pull request Nov 18, 2014
@ueshin @marmbrus
[SPARK-4425][SQL] Handle NaN or Infinity cast to Timestamp correctly.
1a650e7 
`Cast` from `NaN` or `Infinity` of `Double` or `Float` to `TimestampType` throws `NumberFormatException`.

Author: Takuya UESHIN <[email protected]>

Closes #3283 from ueshin/issues/SPARK-4425 and squashes the following commits:

14def0c [Takuya UESHIN] Fix Cast to be able to handle NaN or Infinity to TimestampType.

(cherry picked from commit 566c791)
Signed-off-by: Michael Armbrust <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ueshin @SparkQA @AmplabJenkins @marmbrus