[SPARK-35972][SQL][3.1] When replace ExtractValue in NestedColumnAliasing we should use semanticEquals #33227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we should use semanticEquals
Contributor
Author
|
FYI @viirya |
viirya
changed the title
viirya
approved these changes
Jul 6, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #140692 has finished for PR 33227 at commit
|
Contributor
Author
|
@viirya gen_alias can't have a stable value. just remove the ut? |
viirya
reviewed
Jul 6, 2021
Comment on lines
707
to
709
| $"_extract_search_params".as("value"), | ||
| $"_extract_search_params.col1".as("col1"), | ||
| $"_extract_search_params.col2".as("col2")).analyze |
Member
There was a problem hiding this comment.
You can use collectGeneratedAliases.
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #141122 has finished for PR 33227 at commit
|
viirya
approved these changes
Jul 16, 2021
Member
|
Thanks. Merging to 3.1. |
viirya
pushed a commit
that referenced
this pull request
Jul 16, 2021
…sing we should use semanticEquals ### What changes were proposed in this pull request? Ideally, in SQL query, nested columns should result to GetStructField with non-None name. But there are places that can create GetStructField with None name, such as UnresolvedStar.expand, Dataset encoder stuff, etc. the current `nestedFieldToAlias` cannot catch it up and will cause job failed. ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added UT, Closes #33227 from AngersZhuuuu/SPARK-35972-3.0. Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…sing we should use semanticEquals ### What changes were proposed in this pull request? Ideally, in SQL query, nested columns should result to GetStructField with non-None name. But there are places that can create GetStructField with None name, such as UnresolvedStar.expand, Dataset encoder stuff, etc. the current `nestedFieldToAlias` cannot catch it up and will cause job failed. ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added UT, Closes apache#33227 from AngersZhuuuu/SPARK-35972-3.0. Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
…sing we should use semanticEquals ### What changes were proposed in this pull request? Ideally, in SQL query, nested columns should result to GetStructField with non-None name. But there are places that can create GetStructField with None name, such as UnresolvedStar.expand, Dataset encoder stuff, etc. the current `nestedFieldToAlias` cannot catch it up and will cause job failed. ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added UT, Closes apache#33227 from AngersZhuuuu/SPARK-35972-3.0. Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ideally, in SQL query, nested columns should result to GetStructField with non-None name. But there are places that can create GetStructField with None name, such as UnresolvedStar.expand, Dataset encoder stuff, etc.
the current
nestedFieldToAliascannot catch it up and will cause job failed.Why are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT,