[SPARK-4463] Add (de)select all button for add'l metrics. #3331
Conversation
This commit removes the behavior where when a user clicks "Show additional metrics" on the stage page, all of the additional metrics are automatically selected; now, collapsing and expanding the additional metrics has no effect on which options are selected. Instead, there's a "(De)select All" box at the top; checking this box checks all additional metrics (and similarly, unchecking it unchecks all additional metrics). This commit is intended to be backported to 1.2, so that the additional metrics behavior is not confusing to users.
|
cc @andrewor14 |
|
Test build #23525 has started for PR 3331 at commit
|
|
Nice! I'd prefer to put the select all button at the bottom. Also, it would be good if the words |
|
Test build #23525 has finished for PR 3331 at commit
|
|
Test PASSed. |
|
Thanks for looking at this @andrewor14 ! I added italics but left it at the top -- based on an earlier suggestion of yours that it's good from a UX perspective to minimize the average mouse movement, and I think may people want to just enable all of the options. |
|
Test build #23557 has started for PR 3331 at commit
|
|
Yeah that makes sense, say if we add 20 more options later then the select all button will be too far if it's at the bottom. |
|
Test build #23557 has finished for PR 3331 at commit
|
|
Test FAILed. |
|
retest this please |
|
Test build #23562 has started for PR 3331 at commit
|
|
Test build #23562 has finished for PR 3331 at commit
|
|
Test PASSed. |
|
Ok I'm merging this into master and 1.2 |
|
Thanks Andrew!! |
This commit removes the behavior where when a user clicks "Show additional metrics" on the stage page, all of the additional metrics are automatically selected; now, collapsing and expanding the additional metrics has no effect on which options are selected. Instead, there's a "(De)select All" box at the top; checking this box checks all additional metrics (and similarly, unchecking it unchecks all additional metrics). This commit is intended to be backported to 1.2, so that the additional metrics behavior is not confusing to users. Now when a user clicks the "Show additional metrics" menu, this is what it looks like:  Author: Kay Ousterhout <[email protected]> Closes apache#3331 from kayousterhout/SPARK-4463 and squashes the following commits: 9e17cea [Kay Ousterhout] Added italics b731230 [Kay Ousterhout] [SPARK-4463] Add (de)select all button for add'l metrics.
This commit removes the behavior where when a user clicks "Show additional metrics" on the stage page, all of the additional metrics are automatically selected; now, collapsing and expanding the additional metrics has no effect on which options are selected. Instead, there's a "(De)select All" box at the top; checking this box checks all additional metrics (and similarly, unchecking it unchecks all additional metrics). This commit is intended to be backported to 1.2, so that the additional metrics behavior is not confusing to users. Now when a user clicks the "Show additional metrics" menu, this is what it looks like:  Author: Kay Ousterhout <[email protected]> Closes #3331 from kayousterhout/SPARK-4463 and squashes the following commits: 9e17cea [Kay Ousterhout] Added italics b731230 [Kay Ousterhout] [SPARK-4463] Add (de)select all button for add'l metrics. (cherry picked from commit 010bc86) Signed-off-by: Andrew Or <[email protected]>
4 participants
This commit removes the behavior where when a user clicks
"Show additional metrics" on the stage page, all of the additional
metrics are automatically selected; now, collapsing and expanding
the additional metrics has no effect on which options are selected.
Instead, there's a "(De)select All" box at the top; checking this box
checks all additional metrics (and similarly, unchecking it unchecks
all additional metrics).
This commit is intended to be backported to 1.2, so that the additional
metrics behavior is not confusing to users.
Now when a user clicks the "Show additional metrics" menu, this is what
it looks like: