Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to skip the CRAN check in old branches (than the latest version uploaded to CRAN)

Why are the changes needed?

Same as #33390. Spark 3.2.0 will very likely come first before Spark 3.1.x.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

It will be tested in the CI at this PR.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jul 16, 2021

cc @gengliangwang and @dongjoon-hyun WDYT? The CRAN check is not being failed in branch-3.1 yet but it will be failed once Spark 3.2 is released.

I would just like to fix it now together with #33390 for simplicity since 3.2 will come first before 3.1.x very likely.

If you guys have some concerns, I am also fine with waiting and/or dropping this in branch-3.1.

Copy link
Member

@gengliangwang gengliangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Test build #141151 has finished for PR 33391 at commit 9ae5444.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45663/

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45663/

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Test build #141155 has finished for PR 33391 at commit 1c5bb4a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jul 16, 2021

Merged to branch-3.1

HyukjinKwon added a commit that referenced this pull request Jul 16, 2021
…latest version uploaded

### What changes were proposed in this pull request?

This PR proposes to skip the CRAN check in old branches (than the latest version uploaded to CRAN)

### Why are the changes needed?

Same as #33390. Spark 3.2.0 will very likely come first before Spark 3.1.x.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

It will be tested in the CI at this PR.

Closes #33391 from HyukjinKwon/SPARK-36177.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45667/

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45667/

flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
…latest version uploaded

### What changes were proposed in this pull request?

This PR proposes to skip the CRAN check in old branches (than the latest version uploaded to CRAN)

### Why are the changes needed?

Same as apache#33390. Spark 3.2.0 will very likely come first before Spark 3.1.x.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

It will be tested in the CI at this PR.

Closes apache#33391 from HyukjinKwon/SPARK-36177.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
@HyukjinKwon HyukjinKwon deleted the SPARK-36177 branch January 4, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants