Skip to content

[SPARK-36183][SQL] Push down limit 1 through Aggregate if it is group only #33397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 4 commits into from
Closed

[SPARK-36183][SQL] Push down limit 1 through Aggregate if it is group only #33397

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11c266b
Push down limit 1 through Aggregate if it is group only.
wangyum Jul 16, 2021
c630a63
fix
wangyum Jul 19, 2021
ec3df29
Update comment
wangyum Jul 19, 2021
1d60d64
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/opti…
wangyum Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/opti… 
…mizer/Optimizer.scala

Co-authored-by: Wenchen Fan <[email protected]>
  • Loading branch information
@wangyum @cloud-fan
wangyum and cloud-fan authored Jul 20, 2021
commit 1d60d648aea63000366aa1a51bb5d62dc29e27dd
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ object LimitPushDown extends Rule[LogicalPlan] {
// There is a Project between LocalLimit and Join if they do not have the same output.
case LocalLimit(exp, project @ Project(_, join: Join)) =>
LocalLimit(exp, project.copy(child = pushLocalLimitThroughJoin(exp, join)))
// Push down limit 1 and turn Aggregate into Project through Aggregate if it is group only.
// Push down limit 1 through Aggregate and turn Aggregate into Project if it is group only.
case Limit(le @ IntegerLiteral(1), a: Aggregate) if a.groupOnly =>
Limit(le, Project(a.output, LocalLimit(le, a.child)))
case Limit(le @ IntegerLiteral(1), p @ Project(_, a: Aggregate)) if a.groupOnly =>
Expand Down