Skip to content

[SPARK-4429][BUILD] Build for Scala 2.11 using sbt fails. #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 3 commits into from
Closed

[SPARK-4429][BUILD] Build for Scala 2.11 using sbt fails. #3342

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce98d0f
Set non-empty value to system property "scala-2.11" if the property e…
ueshin Nov 17, 2014
4eef52b
Remove unneeded condition.
ueshin Nov 18, 2014
14d86e8
Add a comment.
ueshin Nov 19, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions project/SparkBuild.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,10 @@ object SparkBuild extends PomBuild {
v.split("(\\s+|,)").filterNot(_.isEmpty).map(_.trim.replaceAll("-P", "")).toSeq
}

if (profiles.exists(_.contains("scala-"))) {
profiles
} else if (System.getProperty("scala-2.11") != null) {
profiles ++ Seq("scala-2.11")
} else {
println("Enabled default scala profile")
profiles ++ Seq("scala-2.10")
if (System.getProperty("scala-2.11") != null && System.getProperty("scala-2.11") == "") {
Copy link
Contributor

@sryza sryza Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something needs "scala-2.11=true", not just "scala-2.11"? Also, does that second condition not include the first?

Copy link
Member Author

@ueshin ueshin Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need the property value is not empty.
sbt build works with -Dscala-2.11=true, but does not work with only -Dscala-2.11.

Ah, you are right, the first condition is not needed.

System.setProperty("scala-2.11", "true")
Copy link
Contributor

@pwendell pwendell Nov 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here and link to the maven code this is replicating? It might be tricky for other developers to understand why this exists.

}
profiles
}

Properties.envOrNone("SBT_MAVEN_PROPERTIES") match {
Copy link
Contributor

@sryza sryza Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we no longer need to turn the scala-2.10 profile on in this case? Will Maven turn it on automatically?

Copy link
Member Author

@ueshin ueshin Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the profile scala-2.10 is activated by the condition:

<property><name>!scala-2.11</name></property>

so Maven will turn it on if the property scala-2.11 is null or empty.

Expand Down