ALS implicit: added missing parameter alpha in doc string #3343
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
So, while we're here, maybe clean a few more things up. "immplicit" is misspelled, and since this is documentation for trainImplicit, there is no implicitPrefs parameter anyway. It's, erm, implicitly true. But these were just true in the text you copied, so can perhaps be fixed elsewhere.
It's really 1 + alpha*R that is the confidence value. alpha sort of controls how difference confidence is in an observed and unobserved interaction. Maybe it's nice to bother to explain a tiny bit more about what this is, in the class scaladoc, and refer to it. While we're here.
The parameter implicitPrefs cannot be set in this context because it is inherent true when calling the trainImplicit method.
|
LGTM. Merged into master and branch-1.2. Thanks! |
Author: Felix Maximilian Möller <[email protected]> Closes apache#3343 from felixmaximilian/fix-documentation and squashes the following commits: 43dcdfb [Felix Maximilian Möller] Removed the information about the switch implicitPrefs. The parameter implicitPrefs cannot be set in this context because it is inherent true when calling the trainImplicit method. 7d172ba [Felix Maximilian Möller] added missing parameter alpha in doc string.
Author: Felix Maximilian Möller <[email protected]> Closes #3343 from felixmaximilian/fix-documentation and squashes the following commits: 43dcdfb [Felix Maximilian Möller] Removed the information about the switch implicitPrefs. The parameter implicitPrefs cannot be set in this context because it is inherent true when calling the trainImplicit method. 7d172ba [Felix Maximilian Möller] added missing parameter alpha in doc string. (cherry picked from commit cedc3b5) Signed-off-by: Xiangrui Meng <[email protected]>
|
@felixmaximilian This was merged but Apache didn't close it automatically. Do you mind closing it? Thanks! |
4 participants
No description provided.