Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into eval
Conflicts:
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
	sql/core/src/main/scala/org/apache/spark/sql/execution/aggregates.scala
  • Loading branch information
rxin committed Apr 7, 2014
commit 9069de6f87f2de97889fc96e7c5144098e48a9c1
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class Projection(expressions: Seq[Expression]) extends (Row => Row) {
def apply(input: Row): Row = {
val outputArray = new Array[Any](exprArray.length)
var i = 0
while (i < exprArray.size) {
while (i < exprArray.length) {
outputArray(i) = exprArray(i).eval(input)
i += 1
}
Expand All @@ -58,7 +58,7 @@ case class MutableProjection(expressions: Seq[Expression]) extends (Row => Row)

def apply(input: Row): Row = {
var i = 0
while (i < exprArray.size) {
while (i < exprArray.length) {
mutableRow(i) = exprArray(i).eval(input)
i += 1
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ abstract class AggregateFunction
override def eval(input: Row): Any

// Do we really need this?
override def newInstance = makeCopy(productIterator.map { case a: AnyRef => a }.toArray)
override def newInstance() = makeCopy(productIterator.map { case a: AnyRef => a }.toArray)
}

case class Count(child: Expression) extends PartialAggregate with trees.UnaryNode[Expression] {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.