Skip to content

[SPARK-36792][SQL] InSet should handle NaN #34033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AngersZhuuuu wants to merge 13 commits into from
Closed

[SPARK-36792][SQL] InSet should handle NaN #34033

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a74a310
[SPARK-36792][SQL] InSet should handle NaN
AngersZhuuuu Sep 17, 2021
320b5ea
Update predicates.scala
AngersZhuuuu Sep 17, 2021
1925e81
Update predicates.scala
AngersZhuuuu Sep 18, 2021
c3addf6
Update PredicateSuite.scala
AngersZhuuuu Sep 18, 2021
141dc5f
Update predicates.scala
AngersZhuuuu Sep 19, 2021
4ad6439
Merge branch 'master' into SPARK-36792
AngersZhuuuu Sep 22, 2021
87df7b0
Update predicates.scala
AngersZhuuuu Sep 23, 2021
174ac71
Update predicates.scala
AngersZhuuuu Sep 23, 2021
a48e77c
Update predicates.scala
AngersZhuuuu Sep 23, 2021
293daea
Update predicates.scala
AngersZhuuuu Sep 23, 2021
4878d5c
Update predicates.scala
AngersZhuuuu Sep 23, 2021
d6d517c
Update predicates.scala
AngersZhuuuu Sep 23, 2021
ef0e81f
trigger
AngersZhuuuu Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update predicates.scala
  • Loading branch information
@AngersZhuuuu
AngersZhuuuu committed Sep 23, 2021
commit 174ac717066e5fce2dcb5c0cd50c8d9149fe5580
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ case class InSet(child: Expression, hset: Set[Any]) extends UnaryExpression with
}

@transient private[this] lazy val hasNull: Boolean = hset.contains(null)
private[this] lazy val isNaN: Any => Boolean = child.dataType match {
@transient private[this] lazy val isNaN: Any => Boolean = child.dataType match {
case DoubleType => (value: Any) => java.lang.Double.isNaN(value.asInstanceOf[java.lang.Double])
case FloatType => (value: Any) => java.lang.Float.isNaN(value.asInstanceOf[java.lang.Float])
case _ => (_: Any) => false
Expand Down