[SPARK-33832][SQL] Force skew join code simplification and improvement #34080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @ulysses-you |
cloud-fan
commented
Sep 23, 2021
| assert(requiredChildOrderings.length == originalChildren.length) | ||
| // Ensure that the operator's children satisfy their output distribution requirements. | ||
| var newChildren = originalChildren.zip(requiredChildDistributions).map { | ||
| var children = originalChildren.zip(requiredChildDistributions).map { |
Contributor
Author
There was a problem hiding this comment.
I feel the original name children is better, as it's a var and we keep updating it.
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #143559 has finished for PR 34080 at commit
|
Contributor
Author
|
thanks for review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #32816 to simplify and improve the code:
SkewJoinChildWrapperto wrap the skew join children, so thatEnsureRequirementsrule will skip them and save timeSkewJoinAwareCostand keep usingSimpleCost. We can putnumSkewsin the first 32 bits.Why are the changes needed?
code simplification and improvement
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing tests