Skip to content

[SQL] Compute timeTaken correctly #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scwf wants to merge 1 commit into from
Closed

[SQL] Compute timeTaken correctly #3423

scwf wants to merge 1 commit into from

Conversation

@scwf
Copy link
Contributor

@scwf scwf commented Nov 24, 2014

timeTaken should not count the time of printing result.

@SparkQA
Copy link

SparkQA commented Nov 24, 2014

Test build #23777 has started for PR 3423 at commit da7e102.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 24, 2014

Test build #23777 has finished for PR 3423 at commit da7e102.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 24, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23777/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented Nov 24, 2014

/cc @liancheng

@scwf
Copy link
Contributor Author

scwf commented Nov 25, 2014

Hive also not count the time of printing, refer to https://github.com/apache/hive/blob/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java#L193-L207

@rxin
Copy link
Contributor

rxin commented Nov 25, 2014

lgtm ...

@liancheng
Copy link
Contributor

liancheng commented Nov 25, 2014

LGTM, thanks!

@rxin
Copy link
Contributor

rxin commented Nov 25, 2014

Ok I'm merging this in master & branch-1.2.

@asfgit asfgit closed this in 723be60 Nov 25, 2014
asfgit pushed a commit that referenced this pull request Nov 25, 2014
@scwf @rxin
[SQL] Compute timeTaken correctly
259cb26 
```timeTaken``` should not count the time of printing result.

Author: w00228970 <[email protected]>

Closes #3423 from scwf/time-taken-bug and squashes the following commits:

da7e102 [w00228970] compute time taken correctly

(cherry picked from commit 723be60)
Signed-off-by: Reynold Xin <[email protected]>
@scwf scwf deleted the time-taken-bug branch November 25, 2014 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@scwf @SparkQA @AmplabJenkins @marmbrus @rxin @liancheng