Skip to content

[SPARK-37203][SQL] Fix NotSerializableException when observe with TypedImperativeAggregate #34474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beliefer wants to merge 6 commits into from
Closed

[SPARK-37203][SQL] Fix NotSerializableException when observe with TypedImperativeAggregate #34474

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1eacf82
Fix NotSerializableException when observe with percentile_approx
beliefer Nov 3, 2021
a2f1fbb
Add test
beliefer Nov 3, 2021
6c2f71c
Improve code
beliefer Nov 4, 2021
84f9657
Improve code
beliefer Nov 4, 2021
5e7afac
Update code
beliefer Nov 4, 2021
acddbf3
Update code
beliefer Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update code
  • Loading branch information
@beliefer
beliefer committed Nov 5, 2021
commit acddbf34e66e70ad64d04b03d300e87049c9b73e
16 changes: 9 additions & 7 deletions sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,14 +755,16 @@ class DatasetSuite extends QueryTest
}

test("SPARK-37203: Fix NotSerializableException when observe with TypedImperativeAggregate") {
val namedObservation = Observation("named")

val df = spark.range(100)
val observed_df = df.observe(
namedObservation, percentile_approx($"id", lit(0.5), lit(100)).as("percentile_approx_val"))
def observe[T](df: Dataset[T], expected: Map[String, _]): Unit = {
val namedObservation = Observation("named")
val observed_df = df.observe(
namedObservation, percentile_approx($"id", lit(0.5), lit(100)).as("percentile_approx_val"))
observed_df.collect()
assert(namedObservation.get === expected)
}

observed_df.collect()
assert(namedObservation.get === Map("percentile_approx_val" -> 49))
observe(spark.range(100), Map("percentile_approx_val" -> 49))
observe(spark.range(0), Map("percentile_approx_val" -> null))
}

test("sample with replacement") {
Expand Down