Skip to content

[SPARK-1434] [MLLIB] change labelParser from anonymous function to trait #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mengxr wants to merge 5 commits into from
Closed

[SPARK-1434] [MLLIB] change labelParser from anonymous function to trait #345

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f8eb36
change labelParser from annoymous function to trait
mengxr Apr 7, 2014
11c94e0
add return types
mengxr Apr 7, 2014
c2e571c
rename LabelParser.apply to LabelParser.parse
mengxr Apr 7, 2014
3b1a7c6
add tests for label parsers
mengxr Apr 8, 2014
ac44409
use singleton objects for label parsers
mengxr Apr 8, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use singleton objects for label parsers
  • Loading branch information
@mengxr
mengxr committed Apr 8, 2014
commit ac444093df8bf395de8bfb7e8cbe9ab5bf7b2fee
20 changes: 8 additions & 12 deletions mllib/src/main/scala/org/apache/spark/mllib/util/LabelParsers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,27 +27,23 @@ trait LabelParser extends Serializable {
* Label parser for binary labels, which outputs 1.0 (positive) if the value is greater than 0.5,
* or 0.0 (negative) otherwise. So it works with +1/-1 labeling and +1/0 labeling.
*/
class BinaryLabelParser extends LabelParser {
object BinaryLabelParser extends LabelParser {
/** Gets the default instance of BinaryLabelParser. */
def getInstance(): LabelParser = this

/**
* Parses the input label into positive (1.0) if the value is greater than 0.5,
* or negative (0.0) otherwise.
*/
override def parse(labelString: String): Double = if (labelString.toDouble > 0.5) 1.0 else 0.0
}

object BinaryLabelParser extends BinaryLabelParser {
/** Gets the default instance of BinaryLabelParser. */
def getInstance(): BinaryLabelParser = this
}

/**
* Label parser for multiclass labels, which converts the input label to double.
*/
class MulticlassLabelParser extends LabelParser {
override def parse(labelString: String): Double = labelString.toDouble
}

object MulticlassLabelParser extends MulticlassLabelParser {
object MulticlassLabelParser extends LabelParser {
/** Gets the default instance of MulticlassLabelParser. */
def getInstance(): MulticlassLabelParser = this
def getInstance(): LabelParser = this

override def parse(labelString: String): Double = labelString.toDouble
}