[SPARK-4516] Avoid allocating Netty PooledByteBufAllocators unnecessarily #3465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors Turns out we are allocating an allocator pool for every TransportClient (which means that the number increases with the number of nodes in the cluster), when really we should just reuse one for all clients. This patch, as expected, massively decreases off-heap memory allocation, and appears to make allocation only proportional to the number of cores.
Contributor
Author
|
This should be merged into 1.2, as it should simply reduce memory issues in containerized environments. |
Contributor
|
LGTM. |
|
Test build #23866 has started for PR 3465 at commit
|
Contributor
|
Thanks aaron, waiting on this to cut rc1 |
aarondav
changed the title
|
Test build #23866 has finished for PR 3465 at commit
|
|
Test PASSed. |
Contributor
|
thanks aaron. that 's very great. |
Contributor
|
Thanks aaron, it's great. |
mengxr
pushed a commit
to mengxr/spark
that referenced
this pull request
Nov 26, 2014
…rily Turns out we are allocating an allocator pool for every TransportClient (which means that the number increases with the number of nodes in the cluster), when really we should just reuse one for all clients. This patch, as expected, greatly decreases off-heap memory allocation, and appears to make allocation only proportional to the number of cores. Author: Aaron Davidson <[email protected]> Closes apache#3465 from aarondav/fewer-pools and squashes the following commits: 36c49da [Aaron Davidson] [SPARK-4516] Avoid allocating unnecessarily Netty PooledByteBufAllocators (cherry picked from commit 346bc17) Signed-off-by: Patrick Wendell <[email protected]>
Contributor
Author
|
Merging into master and branch-1.2. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we are allocating an allocator pool for every TransportClient (which means that the number increases with the number of nodes in the cluster), when really we should just reuse one for all clients.
This patch, as expected, greatly decreases off-heap memory allocation, and appears to make allocation only proportional to the number of cores.