[SPARK-37388][SQL] Fix NPE in WidthBucket in WholeStageCodegenExec #34670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145458 has finished for PR 34670 at commit
|
c21
reviewed
Nov 19, 2021
Contributor
c21
left a comment
c21
left a comment
There was a problem hiding this comment.
Thank you @tomvanbussel for the fix!
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
Show resolved
Hide resolved
...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
Show resolved
Hide resolved
...catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
Show resolved
Hide resolved
Contributor
Author
|
Thank you for the review @c21! I will add the additional test case and I have provided answers to your questions. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145466 has finished for PR 34670 at commit
|
Member
|
retest this please |
Member
|
Test failure seems unrelated but mind retriggering for doubly sure, @tomvanbussel? https://github.com/tomvanbussel/spark/actions/runs/1482727001 |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145487 has finished for PR 34670 at commit
|
Contributor
|
Seems the GA job OOMed, I'm merging this to master/3.2/3.1, thanks! |
cloud-fan
pushed a commit
that referenced
this pull request
Nov 22, 2021
This PR fixes a `NullPointerException` in `WholeStageCodegenExec` caused by the expression `WidthBucket`. The cause of this NPE is that `WidthBucket` calls `WidthBucket.computeBucketNumber`, which can return `null`, but the generated code cannot deal with `null`s. This fixes a `NullPointerException` in Spark SQL. No Added tests to `MathExpressionsSuite`. This suite already had tests for `WidthBucket` with interval inputs, but lacked tests with double inputs. I checked that the tests failed without the fix, and succeed with the fix. Closes #34670 from tomvanbussel/SPARK-37388. Authored-by: Tom van Bussel <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 77f3974) Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan
pushed a commit
that referenced
this pull request
Nov 22, 2021
This PR fixes a `NullPointerException` in `WholeStageCodegenExec` caused by the expression `WidthBucket`. The cause of this NPE is that `WidthBucket` calls `WidthBucket.computeBucketNumber`, which can return `null`, but the generated code cannot deal with `null`s. This fixes a `NullPointerException` in Spark SQL. No Added tests to `MathExpressionsSuite`. This suite already had tests for `WidthBucket` with interval inputs, but lacked tests with double inputs. I checked that the tests failed without the fix, and succeed with the fix. Closes #34670 from tomvanbussel/SPARK-37388. Authored-by: Tom van Bussel <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 77f3974) Signed-off-by: Wenchen Fan <[email protected]>
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Dec 8, 2021
This PR fixes a `NullPointerException` in `WholeStageCodegenExec` caused by the expression `WidthBucket`. The cause of this NPE is that `WidthBucket` calls `WidthBucket.computeBucketNumber`, which can return `null`, but the generated code cannot deal with `null`s. This fixes a `NullPointerException` in Spark SQL. No Added tests to `MathExpressionsSuite`. This suite already had tests for `WidthBucket` with interval inputs, but lacked tests with double inputs. I checked that the tests failed without the fix, and succeed with the fix. Closes apache#34670 from tomvanbussel/SPARK-37388. Authored-by: Tom van Bussel <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 77f3974) Signed-off-by: Wenchen Fan <[email protected]>
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
This PR fixes a `NullPointerException` in `WholeStageCodegenExec` caused by the expression `WidthBucket`. The cause of this NPE is that `WidthBucket` calls `WidthBucket.computeBucketNumber`, which can return `null`, but the generated code cannot deal with `null`s. This fixes a `NullPointerException` in Spark SQL. No Added tests to `MathExpressionsSuite`. This suite already had tests for `WidthBucket` with interval inputs, but lacked tests with double inputs. I checked that the tests failed without the fix, and succeed with the fix. Closes apache#34670 from tomvanbussel/SPARK-37388. Authored-by: Tom van Bussel <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 77f3974) Signed-off-by: Wenchen Fan <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Feb 22, 2022
This PR fixes a `NullPointerException` in `WholeStageCodegenExec` caused by the expression `WidthBucket`. The cause of this NPE is that `WidthBucket` calls `WidthBucket.computeBucketNumber`, which can return `null`, but the generated code cannot deal with `null`s. This fixes a `NullPointerException` in Spark SQL. No Added tests to `MathExpressionsSuite`. This suite already had tests for `WidthBucket` with interval inputs, but lacked tests with double inputs. I checked that the tests failed without the fix, and succeed with the fix. Closes apache#34670 from tomvanbussel/SPARK-37388. Authored-by: Tom van Bussel <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 77f3974) Signed-off-by: Wenchen Fan <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Mar 4, 2022
This PR fixes a `NullPointerException` in `WholeStageCodegenExec` caused by the expression `WidthBucket`. The cause of this NPE is that `WidthBucket` calls `WidthBucket.computeBucketNumber`, which can return `null`, but the generated code cannot deal with `null`s. This fixes a `NullPointerException` in Spark SQL. No Added tests to `MathExpressionsSuite`. This suite already had tests for `WidthBucket` with interval inputs, but lacked tests with double inputs. I checked that the tests failed without the fix, and succeed with the fix. Closes apache#34670 from tomvanbussel/SPARK-37388. Authored-by: Tom van Bussel <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 77f3974) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a
NullPointerExceptioninWholeStageCodegenExeccaused by the expressionWidthBucket. The cause of this NPE is thatWidthBucketcallsWidthBucket.computeBucketNumber, which can returnnull, but the generated code cannot deal withnulls.Why are the changes needed?
This fixes a
NullPointerExceptionin Spark SQL.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added tests to
MathExpressionsSuite. This suite already had tests forWidthBucketwith interval inputs, but lacked tests with double inputs. I checked that the tests failed without the fix, and succeed with the fix.