Skip to content

[SPARK-37654][SQL] Fix NPE in Row.getSeq when field is Null #34928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
huaxingao wants to merge 1 commit into from
Closed

[SPARK-37654][SQL] Fix NPE in Row.getSeq when field is Null #34928

huaxingao wants to merge 1 commit into from

Conversation

@huaxingao
Copy link
Contributor

@huaxingao huaxingao commented Dec 17, 2021 •
edited
Loading

What changes were proposed in this pull request?

Fix NPE

scala> Row(null).getSeq(0)
java.lang.NullPointerException
  at org.apache.spark.sql.Row.getSeq(Row.scala:319)
  at org.apache.spark.sql.Row.getSeq$(Row.scala:319)
  at org.apache.spark.sql.catalyst.expressions.GenericRow.getSeq(rows.scala:166)

Why are the changes needed?

bug fixing

Does this PR introduce any user-facing change?

No

How was this patch tested?

new UT

@github-actions github-actions bot added the SQL label Dec 17, 2021
@SparkQA
Copy link

SparkQA commented Dec 17, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50779/

@SparkQA
Copy link

SparkQA commented Dec 17, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50779/

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 17, 2021

Merged to master, branch-3.2 and branch-3.1.

HyukjinKwon pushed a commit that referenced this pull request Dec 17, 2021
@huaxingao @HyukjinKwon
[SPARK-37654][SQL] Fix NPE in Row.getSeq when field is Null
255e82e 
### What changes were proposed in this pull request?
Fix NPE
```
scala> Row(null).getSeq(0)
java.lang.NullPointerException
  at org.apache.spark.sql.Row.getSeq(Row.scala:319)
  at org.apache.spark.sql.Row.getSeq$(Row.scala:319)
  at org.apache.spark.sql.catalyst.expressions.GenericRow.getSeq(rows.scala:166)
```

### Why are the changes needed?
bug fixing

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
new UT

Closes #34928 from huaxingao/npe.

Authored-by: Huaxin Gao <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit fcf636d)
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon pushed a commit that referenced this pull request Dec 17, 2021
@huaxingao @HyukjinKwon
[SPARK-37654][SQL] Fix NPE in Row.getSeq when field is Null
1706ccc 
### What changes were proposed in this pull request?
Fix NPE
```
scala> Row(null).getSeq(0)
java.lang.NullPointerException
  at org.apache.spark.sql.Row.getSeq(Row.scala:319)
  at org.apache.spark.sql.Row.getSeq$(Row.scala:319)
  at org.apache.spark.sql.catalyst.expressions.GenericRow.getSeq(rows.scala:166)
```

### Why are the changes needed?
bug fixing

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
new UT

Closes #34928 from huaxingao/npe.

Authored-by: Huaxin Gao <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit fcf636d)
Signed-off-by: Hyukjin Kwon <[email protected]>
@huaxingao
Copy link
Contributor Author

huaxingao commented Dec 17, 2021

Thanks! @HyukjinKwon

@huaxingao huaxingao deleted the npe branch December 17, 2021 05:17
@SparkQA
Copy link

SparkQA commented Dec 17, 2021

Test build #146307 has finished for PR 34928 at commit c021436.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Dec 17, 2021

+1, LGTM.

fishcus pushed a commit to fishcus/spark that referenced this pull request Jan 12, 2022
@huaxingao @fishcus
[SPARK-37654][SQL] Fix NPE in Row.getSeq when field is Null
918c222 
### What changes were proposed in this pull request?
Fix NPE
```
scala> Row(null).getSeq(0)
java.lang.NullPointerException
  at org.apache.spark.sql.Row.getSeq(Row.scala:319)
  at org.apache.spark.sql.Row.getSeq$(Row.scala:319)
  at org.apache.spark.sql.catalyst.expressions.GenericRow.getSeq(rows.scala:166)
```

### Why are the changes needed?
bug fixing

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
new UT

Closes apache#34928 from huaxingao/npe.

Authored-by: Huaxin Gao <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit fcf636d)
Signed-off-by: Hyukjin Kwon <[email protected]>
catalinii pushed a commit to lyft/spark that referenced this pull request Feb 22, 2022
@huaxingao
[SPARK-37654][SQL] Fix NPE in Row.getSeq when field is Null
8acad1d 
### What changes were proposed in this pull request?
Fix NPE
```
scala> Row(null).getSeq(0)
java.lang.NullPointerException
  at org.apache.spark.sql.Row.getSeq(Row.scala:319)
  at org.apache.spark.sql.Row.getSeq$(Row.scala:319)
  at org.apache.spark.sql.catalyst.expressions.GenericRow.getSeq(rows.scala:166)
```

### Why are the changes needed?
bug fixing

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
new UT

Closes apache#34928 from huaxingao/npe.

Authored-by: Huaxin Gao <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit fcf636d)
Signed-off-by: Hyukjin Kwon <[email protected]>
catalinii pushed a commit to lyft/spark that referenced this pull request Mar 4, 2022
@huaxingao @catalinii
[SPARK-37654][SQL] Fix NPE in Row.getSeq when field is Null
ac2d07b 
### What changes were proposed in this pull request?
Fix NPE
```
scala> Row(null).getSeq(0)
java.lang.NullPointerException
  at org.apache.spark.sql.Row.getSeq(Row.scala:319)
  at org.apache.spark.sql.Row.getSeq$(Row.scala:319)
  at org.apache.spark.sql.catalyst.expressions.GenericRow.getSeq(rows.scala:166)
```

### Why are the changes needed?
bug fixing

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
new UT

Closes apache#34928 from huaxingao/npe.

Authored-by: Huaxin Gao <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit fcf636d)
Signed-off-by: Hyukjin Kwon <[email protected]>
kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
@huaxingao @dongjoon-hyun
[SPARK-37654][SQL] Fix NPE in Row.getSeq when field is Null
f8ccc2a 
### What changes were proposed in this pull request?
Fix NPE
```
scala> Row(null).getSeq(0)
java.lang.NullPointerException
  at org.apache.spark.sql.Row.getSeq(Row.scala:319)
  at org.apache.spark.sql.Row.getSeq$(Row.scala:319)
  at org.apache.spark.sql.catalyst.expressions.GenericRow.getSeq(rows.scala:166)
```

### Why are the changes needed?
bug fixing

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
new UT

Closes apache#34928 from huaxingao/npe.

Authored-by: Huaxin Gao <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit fcf636d)
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huaxingao @SparkQA @HyukjinKwon @dongjoon-hyun