Skip to content

[SPARK-35714][FOLLOW-UP][CORE] WorkerWatcher should run System.exit in a thread out of RpcEnv #35069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ngone51 wants to merge 1 commit into from
Closed

[SPARK-35714][FOLLOW-UP][CORE] WorkerWatcher should run System.exit in a thread out of RpcEnv #35069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/src/main/scala/org/apache/spark/deploy/worker/WorkerWatcher.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ private[spark] class WorkerWatcher(
if (isTesting) {
isShutDown = true
} else if (isChildProcessStopping.compareAndSet(false, true)) {
// SPARK-35714: avoid the duplicate call of `System.exit` to avoid the dead lock
System.exit(-1)
// SPARK-35714: avoid the duplicate call of `System.exit` to avoid the dead lock.
// Same as SPARK-14180, we should run `System.exit` in a separate thread to avoid
// dead lock since `System.exit` will trigger the shutdown hook of `executor.stop`.
new Thread("WorkerWatcher-exit-executor") {
override def run(): Unit = System.exit(-1)
}.start()
}

override def receive: PartialFunction[Any, Unit] = {
Expand Down