Revert "[SPARK-35746][UI] Fix taskid in the stage page task event tim… #35155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eline" This reverts commit 450b415.
dongjoon-hyun
requested changes
Jan 10, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Hi, @stczwd .
This revert PR is invalid because SPARK-35746 was released already.
If you want this, you need to file a new Bug-type JIRA issue and related it to SPARK-35746 with caused by relationship. Please proceed in that way.
BTW, please ping the original author and committers on your new JIRA and PRs.
Contributor
Author
|
Sure, I can create a new JIRA and PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This reverts commit 450b415.
Why are the changes needed?
In #32888, @shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use
index.attemptortaskIdto distinguish tasks within a stage, nottaskId.attempt.Thus #32888 was a wrong fix issue, we should revert it.
Does this PR introduce any user-facing change?
no
How was this patch tested?
origin test suites