Skip to content

[SPARK-38067][PYTHON] Preserve None values when saved to JSON. #35296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjornjorgensen wants to merge 15 commits into from
Closed

[SPARK-38067][PYTHON] Preserve None values when saved to JSON. #35296

Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
196d14f
SPARK-37981 Add note for deleting Null and NaN
bjornjorgensen Jan 23, 2022
a073be4
Set ignoreNullFields to False
bjornjorgensen Jan 24, 2022
670c690
Removed note
bjornjorgensen Jan 24, 2022
da2da56
Removed extra space.
bjornjorgensen Jan 24, 2022
fc659ca
Fix new line
bjornjorgensen Jan 24, 2022
d6f5b53
Updated options to more Pandas-specific defaults as a dict.
bjornjorgensen Jan 25, 2022
4349d0b
Merge branch 'apache:master' into SPARK-37981-Add-note-for-deleting-N…
bjornjorgensen Jan 25, 2022
d8de0c5
Set it as a note.
bjornjorgensen Jan 25, 2022
8ffbef2
Fix indenting
bjornjorgensen Jan 25, 2022
0d4794c
Update python/pyspark/pandas/generic.py
bjornjorgensen Jan 25, 2022
fec39c7
Update python/pyspark/pandas/generic.py
bjornjorgensen Jan 25, 2022
99100ac
moved merging default_options after if-clause
bjornjorgensen Jan 25, 2022
cd6737b
Removed new line
bjornjorgensen Jan 25, 2022
d992250
Merge remote-tracking branch 'origin/SPARK-37981-Add-note-for-deletin…
bjornjorgensen Jan 28, 2022
c2df065
Add Dict, to import
bjornjorgensen Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions python/pyspark/pandas/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,7 @@ def to_json(
lines: bool = True,
partition_cols: Optional[Union[str, List[str]]] = None,
index_col: Optional[Union[str, List[str]]] = None,
ignoreNullFields: bool = False,
**options: Any,
) -> Optional[str]:
"""
Expand All @@ -904,6 +905,9 @@ def to_json(

.. note:: output JSON format is different from pandas'. It always use `orient='records'`
for its output. This behaviour might have to change in the near future.

.. note:: Set ignoreNullFields keyword argument to `True` and path is provided,
writer omits columns with all NaN or Null values.

Note NaN's and None will be converted to null and datetime objects
will be converted to UNIX timestamps.
Expand Down Expand Up @@ -978,6 +982,9 @@ def to_json(
0 a
1 c
"""
default_options: Dict[str, Any] = {"ignoreNullFields": False}
options = {**default_options, **options}

if "options" in options and isinstance(options.get("options"), dict) and len(options) == 1:
options = options.get("options")

Expand Down