Skip to content

[SPARK-4717][MLlib] Optimize BLAS library to avoid de-reference multiple times in loop #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbtsai wants to merge 2 commits into from
Closed

[SPARK-4717][MLlib] Optimize BLAS library to avoid de-reference multiple times in loop #3577

dbtsai wants to merge 2 commits into from

Conversation

@dbtsai
Copy link
Member

@dbtsai dbtsai commented Dec 3, 2014

Have a local reference to values and indices array in the Vector object
so JVM can locate the value with one operation call. See SPARK-4581
for similar optimization, and the bytecode analysis.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24083 has started for PR 3577 at commit 0316cef.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24085 has started for PR 3577 at commit 62d38c4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24083 has finished for PR 3577 at commit 0316cef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 3, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24083/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Dec 3, 2014

Test build #24085 has finished for PR 3577 at commit 62d38c4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 3, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24085/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Dec 3, 2014

LGTM. Merged into master and branch-1.2. Thanks!

asfgit pushed a commit that referenced this pull request Dec 3, 2014
@mengxr
[SPARK-4717][MLlib] Optimize BLAS library to avoid de-reference multi…
b63e941 
…ple times in loop

Have a local reference to `values` and `indices` array in the `Vector` object
so JVM can locate the value with one operation call. See `SPARK-4581`
for similar optimization, and the bytecode analysis.

Author: DB Tsai <[email protected]>

Closes #3577 from dbtsai/blasopt and squashes the following commits:

62d38c4 [DB Tsai] formating
0316cef [DB Tsai] first commit

(cherry picked from commit d005429)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in d005429 Dec 3, 2014
@dbtsai dbtsai deleted the blasopt branch December 3, 2014 19:21
@dbtsai dbtsai mentioned this pull request Dec 9, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbtsai @SparkQA @AmplabJenkins @mengxr