[SPARK-39060][SQL] Typo in error messages of decimal overflow #36397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunchao
approved these changes
Apr 28, 2022
HyukjinKwon
approved these changes
Apr 29, 2022
Member
|
seems like some more tests should be fixed tho. |
MaxGekk
approved these changes
Apr 29, 2022
singhpk234
approved these changes
Apr 29, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
Outdated
Show resolved
Hide resolved
|
Can one of the admins verify this patch? |
Member
|
+1, LGTM. Merging to master. |
Member
|
@vli-databricks Could you backport the changes to branch-3.3 (the PR causes conflicts in 3.3 while merging), please. |
vitaliili-db
added a commit
to vitaliili-db/spark
that referenced
this pull request
May 4, 2022
This PR removes extra curly bracket from debug string for Decimal type in SQL. Typo in error messages of decimal overflow. No. By running updated test: ``` $ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z decimalArithmeticOperations.sql" ``` Closes apache#36397 from vli-databricks/SPARK-39060. Authored-by: Vitalii Li <[email protected]> Signed-off-by: Max Gekk <[email protected]>
vitaliili-db
added a commit
to vitaliili-db/spark
that referenced
this pull request
May 5, 2022
This PR removes extra curly bracket from debug string for Decimal type in SQL. Typo in error messages of decimal overflow. No. By running updated test: ``` $ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z decimalArithmeticOperations.sql" ``` Closes apache#36397 from vli-databricks/SPARK-39060. Authored-by: Vitalii Li <[email protected]> Signed-off-by: Max Gekk <[email protected]>
vitaliili-db
added a commit
to vitaliili-db/spark
that referenced
this pull request
May 5, 2022
This PR removes extra curly bracket from debug string for Decimal type in SQL. Typo in error messages of decimal overflow. No. By running updated test: ``` $ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z decimalArithmeticOperations.sql" ``` Closes apache#36397 from vli-databricks/SPARK-39060. Authored-by: Vitalii Li <[email protected]> Signed-off-by: Max Gekk <[email protected]>
vitaliili-db
added a commit
to vitaliili-db/spark
that referenced
this pull request
May 5, 2022
This PR removes extra curly bracket from debug string for Decimal type in SQL. Typo in error messages of decimal overflow. No. By running updated test: ``` $ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z decimalArithmeticOperations.sql" ``` Closes apache#36397 from vli-databricks/SPARK-39060. Authored-by: Vitalii Li <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes extra curly bracket from debug string for Decimal type in SQL.
Why are the changes needed?
Typo in error messages of decimal overflow.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running updated test: