Skip to content

[SPARK-36462][K8S] Add the ability to selectively disable watching or polling #36433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holdenk wants to merge 11 commits into from
Closed

[SPARK-36462][K8S] Add the ability to selectively disable watching or polling #36433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2ed6c6b
Add the ability to selectively disable watching or polling for pods o…
holdenk Oct 12, 2021
efa0e5a
CR-feedback
holdenk May 2, 2022
eac0698
Update resource-managers/kubernetes/core/src/main/scala/org/apache/sp…
holdenk May 3, 2022
a030c0b
Update resource-managers/kubernetes/core/src/main/scala/org/apache/sp…
holdenk May 3, 2022
346f40f
Update resource-managers/kubernetes/core/src/test/scala/org/apache/sp…
holdenk May 3, 2022
6fef69d
Update resource-managers/kubernetes/core/src/main/scala/org/apache/sp…
holdenk May 3, 2022
c8523c1
CR feedback it's enableWatching not polling update var name to match.
holdenk May 3, 2022
9137c4d
Update version since we missed the boat on 3.3.0
holdenk Jun 28, 2022
f0db5a7
Fix style
holdenk Jun 28, 2022
adf4e9a
Move internal up above booleanConf
holdenk Aug 10, 2022
9f5d460
CR Feedback: add back legacy two parameter constructor, use default r…
holdenk Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CR-feedback
  • Loading branch information
@holdenk
holdenk committed Aug 11, 2022
commit efa0e5a5dc4a1a7bdf42a44b3fbe5d652fc7a316
2 changes: 2 additions & 0 deletions resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,7 @@ private[spark] object Config extends Logging {
"You should leave this enabled unless your encountering performance issues with your etcd.")
.version("3.3.0")
.booleanConf
.internal()
.createWithDefault(true)

val KUBERNETES_EXECUTOR_ENABLE_API_WATCHER =
Expand All @@ -497,6 +498,7 @@ private[spark] object Config extends Logging {
"You should leave this enabled unless your encountering performance issues with your etcd.")
.version("3.3.0")
.booleanConf
.internal()
.createWithDefault(true)


Expand Down
2 changes: 1 addition & 1 deletion ...scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class ExecutorPodsPollingSnapshotSourceSuite extends SparkFunSuite with BeforeAn
verify(eventQueue).replaceSnapshot(Seq(exec1, exec2))
}

test("If polling is disabled we don't call pods() on the client") {
test("SPARK-36462: If polling is disabled we don't call pods() on the client") {
val sparkConf = new SparkConf()
val source = new ExecutorPodsPollingSnapshotSource(
sparkConf.set(KUBERNETES_EXECUTOR_ENABLE_API_POLLING, false),
Expand Down