[SPARK-39249][SQL] Improve subexpression elimination for conditional expressions #36626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@viirya @cloud-fan Could you please help review this? |
|
Can one of the admins verify this patch? |
Contributor
|
FYI I created #32987 a while ago to address this in a more general way. I've tried to keep it up to date, but there seemed to be concerns about creating a subexpression for something that might only execute once I guess? Even though that's already happening in certain cases |
Contributor
Author
|
@viirya @cloud-fan Could you please help review this? |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently we can do subexpression elimination for conditional expressions when the subexpression is common across all
branchGroups. In fact, we can farther improve this when there are common expressions betweenalwaysEvaluatedInputsandbranchGroups.Why are the changes needed?
Take the following case as an example
amay miss subexpression elimination chances since it is not the common expression between allbranchGroups, but it's safe to evaluateaas common subexpression and eagerly execute it since it's part of the prediction, which will always be executed. Ifais a time-expensive expression, we may waste time on running it.This kind of expressions are common when we do
sumon decimal type because of #29026spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala
Line 125 in 291d155
Many queries on TPC-DS has positive improvement. Following is some obvious improvements on TPC-DS 10T
Does this PR introduce any user-facing change?
No
How was this patch tested?
add more UT.