-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-39731][SQL] Fix issue in CSV and JSON data sources when parsing dates in "yyyyMMdd" format with CORRECTED time parser policy #37147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1193ce7
fix issue
sadikovi b714b7f
update code
sadikovi 8a10a68
fix issue in json
sadikovi 9b65761
update code
sadikovi 45011a0
add a config option to control legacy behavior
sadikovi 40d07bd
add a config for json
sadikovi 55c5579
update docs and comments
sadikovi ef91606
fix scalastyle
sadikovi 15c07f7
trigger ci
sadikovi a83288b
update comments
sadikovi bf9351d
trigger ci
sadikovi ac63b63
Merge remote-tracking branch 'upstream/master' into fix-csv-date-infe…
sadikovi a447b08
fix tests for SPARK-39469
sadikovi 8feb707
Merge remote-tracking branch 'upstream/master' into fix-csv-date-infe…
sadikovi 8a01ece
Merge remote-tracking branch 'upstream/master' into fix-csv-date-infe…
sadikovi fbdf9d8
update comments
sadikovi 2962cd9
Revert "fix tests for SPARK-39469"
sadikovi 10ca4a4
update the priority order for SPARK-39469
sadikovi b2a3db2
trigger ci
sadikovi 739e7db
Merge remote-tracking branch 'upstream/master' into fix-csv-date-infe…
sadikovi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness, would you consider adding a check for
LEGACY_TIME_PARSER_POLICY=EXCEPTION? Similar to the following?spark/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
Lines 2598 to 2601 in 1193ce7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!