Skip to content

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Sep 9, 2022

What changes were proposed in this pull request?

This pr update scalatest and scalatestplus related dependencies to use stable version as follows:

  • Upgrade scala-xml from 1.20 to 2.1.0 to support scalatest 3.2.13

  • Update org.scalatest:scalatest from 3.3.0-SNAP3 to 3.2.13

  • Update org.scalatestplus:scalacheck-1-15:3.3.0-SNAP3 to org.scalatestplus:scalacheck-1-16:3.2.13.0 and upgrade scalacheck from 1.15.4 to 1.16.0

  • Update org.scalatestplus:selenium-3-141:3.3.0.0-SNAP3 to org.scalatestplus:selenium-3-141:3.2.10.0 and left TODO of SPARK-40397.

Why are the changes needed?

Change to use stable version dependencies.

The relevant release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

SPARK_GENERATE_GOLDEN_FILES=1 build/sbt clean "sql/testOnly *PlanStability*Suite"
[info] Run completed in 52 seconds, 520 milliseconds.
[info] Total number of tests run: 334
[info] Suites: completed 7, aborted 0
[info] Tests: succeeded 334, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

@LuciferYang LuciferYang changed the title [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use 3.2.13 [WIP][SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use 3.2.13 Sep 9, 2022
@github-actions github-actions bot added the BUILD label Sep 9, 2022
@LuciferYang LuciferYang changed the title [WIP][SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use 3.2.13 [WIP][SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version Sep 9, 2022
@LuciferYang LuciferYang changed the title [WIP][SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version Sep 9, 2022
@LuciferYang LuciferYang marked this pull request as draft September 9, 2022 08:41
<groupId>org.scala-lang.modules</groupId>
<artifactId>scala-xml_${scala.binary.version}</artifactId>
<version>1.2.0</version>
<version>2.1.0</version>
Copy link
Contributor Author

@LuciferYang LuciferYang Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try update this due to

image

@LuciferYang LuciferYang marked this pull request as ready for review September 10, 2022 11:56
@MaxGekk
Copy link
Member

MaxGekk commented Sep 11, 2022

+1, LGTM. Merging to master.
Thank you, @LuciferYang and @srowen for review.

@MaxGekk MaxGekk closed this in 78d492c Sep 11, 2022
@LuciferYang
Copy link
Contributor Author

thanks @srowen and @MaxGekk

@pan3793
Copy link
Member

pan3793 commented Sep 13, 2022

branch-3.3 uses the abandoned version 3.3.0-SNAP3 now, I suggest we backport this PR to branch-3.3 cc @wangyum

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Sep 13, 2022

branch-3.3 uses the abandoned version 3.3.0-SNAP3 now, I suggest we backport this PR to branch-3.3 cc @wangyum

This pr also upgrade scala-xml from 1.20 to 2.1.0, maybe we need try to find a version that doesn't need to upgrade scala-xml for branch-3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants