[SPARK-40663][SQL] Migrate execution errors onto error classes: _LEGACY_ERROR_TEMP_2101-2125 #38123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LEGACY_ERROR_TEMP_2101-2125
itholic
changed the title
Contributor
Author
|
FYI @MaxGekk @cloud-fan Test passed! |
Member
|
@itholic Thank you for the ping. I will review this PR today. |
MaxGekk
approved these changes
Oct 12, 2022
Member
|
+1, LGTM. Merging to master. |
MaxGekk
reviewed
Nov 5, 2022
| def cannotParseStatisticAsPercentileError( | ||
| stats: String, e: NumberFormatException): Throwable = { | ||
| new IllegalArgumentException(s"Unable to parse $stats as a percentile", e) | ||
| stats: String, e: NumberFormatException): SparkIllegalArgumentException = { |
Member
There was a problem hiding this comment.
@itholic You just ignored e? Seems like some kind of regression. Could you add a constructor to SparkIllegalArgumentException which accepts cause too.
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing out.
Let me address it with #38104 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to migrate 25 execution errors onto temporary error classes with the prefix
_LEGACY_ERROR_TEMP_2101to_LEGACY_ERROR_TEMP_2125.The error classes are prefixed with
_LEGACY_ERROR_TEMP_indicates the dev-facing error messages, and won't be exposed to end users.Why are the changes needed?
To speed-up the error class migration.
The migration on temporary error classes allow us to analyze the errors, so we can detect the most popular error classes.
Does this PR introduce any user-facing change?
No
How was this patch tested?