-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR] Fix grammar in error message #38165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a6ecf4 to
b724bbc
Compare
|
You may have to check the test failure, but OK |
b724bbc to
5061845
Compare
|
Can one of the admins verify this patch? |
|
Looks like the failing test needs an update on the error message. Otherwise LGTM. |
|
@amaliujia can you point me to the failing test please? There's 212,798 lines in the log, the word "error" appears 11,800 times. I don't know where the actual error is. Feel free to finish this, here's the commands I ran: git grep -l 'the compatible' | xargs sed -i '' -e 's/the compatible/compatible/g'
git grep -l 'same column of first table' | xargs sed -i '' -e 's/same column of first table/the same column of the first table/g' |
5061845 to
60a15ce
Compare
|
Thanks, fixed |
zhengruifeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just wondering if there is some spell checker plugin?
|
I'm getting a weird error from the merge script on merging this - is anyone else seeing it? other PRs seem fine. |
|
Merged to master. |

No description provided.