Skip to content

Conversation

@verhovsky
Copy link
Contributor

No description provided.

@srowen srowen changed the title Fix grammar in error message [MINOR] Fix grammar in error message Oct 8, 2022
@srowen
Copy link
Member

srowen commented Oct 8, 2022

You may have to check the test failure, but OK

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@amaliujia
Copy link
Contributor

Looks like the failing test needs an update on the error message.

Otherwise LGTM.

@verhovsky
Copy link
Contributor Author

verhovsky commented Oct 10, 2022

@amaliujia can you point me to the failing test please? There's 212,798 lines in the log, the word "error" appears 11,800 times. I don't know where the actual error is. Feel free to finish this, here's the commands I ran:

git grep -l 'the compatible' | xargs sed -i '' -e 's/the compatible/compatible/g'
git grep -l 'same column of first table' | xargs sed -i '' -e 's/same column of first table/the same column of the first table/g'

@amaliujia
Copy link
Contributor

@verhovsky

there is a failed test report at the bottom of those jobs that you can see the summary of the failing tests:
Screen Shot 2022-10-10 at 10 59 56 AM

@verhovsky
Copy link
Contributor Author

Thanks, fixed

Copy link
Contributor

@zhengruifeng zhengruifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just wondering if there is some spell checker plugin?

@srowen
Copy link
Member

srowen commented Oct 11, 2022

I'm getting a weird error from the merge script on merging this - is anyone else seeing it? other PRs seem fine.

Traceback (most recent call last):
  File "/Users/sean.owen/Documents/spark/./dev/merge_spark_pr.py", line 599, in <module>
    main()
  File "/Users/sean.owen/Documents/spark/./dev/merge_spark_pr.py", line 511, in main
    modified_body = re.sub(re.compile(r"<!--[^>]*-->\n?", re.DOTALL), "", pr["body"]).lstrip()
  File "/usr/local/Cellar/[email protected]/3.10.7/Frameworks/Python.framework/Versions/3.10/lib/python3.10/re.py", line 209, in sub
    return _compile(pattern, flags).sub(repl, string, count)

@srowen
Copy link
Member

srowen commented Oct 11, 2022

Merged to master.
I figured out the script problem and will fix it

@srowen srowen closed this in 1103d29 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants