[SPARK-40725][INFRA] Add mypy-protobuf to dev/requirements
#38186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Oct 10, 2022
Member
|
@Yikun, this PR doesn't require the CI to pass. Wanna try to merge this PR? |
Yikun
approved these changes
Oct 10, 2022
Member
Yikun
left a comment
Yikun
left a comment
There was a problem hiding this comment.
LGTM
@HyukjinKwon Sure, I'd like to have a try! Thanks
Contributor
Author
|
thanks @Yikun @HyukjinKwon |
Member
|
@zhengruifeng @HyukjinKwon Thanks! |
Contributor
|
Late +1! I found this in my branch then I found it's fixed so fast! |
DeZepTup
pushed a commit
to DeZepTup/spark-custom
that referenced
this pull request
Oct 31, 2022
### What changes were proposed in this pull request?
Add `mypy-protobuf` to dev/requirements
### Why are the changes needed?
`connector/connect/dev/generate_protos.sh` requires this package:
```
DEBUG /buf.alpha.registry.v1alpha1.GenerateService/GeneratePlugins {"duration": "14.25µs", "http.path": "/buf.alpha.registry.v1alpha1.GenerateService/GeneratePlugins", "http.url": "https://api.buf.build/buf.alpha.registry.v1alpha1.GenerateService/GeneratePlugins", "http.host": "api.buf.build", "http.method": "POST", "http.user_agent": "connect-go/0.4.0-dev (go1.19.2)"}
DEBUG command {"duration": "9.238333ms"}
Failure: plugin mypy: could not find protoc plugin for name mypy
```
### Does this PR introduce _any_ user-facing change?
No, only for contributors
### How was this patch tested?
manually check
Closes apache#38186 from zhengruifeng/add_mypy-protobuf_to_requirements.
Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Yikun Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
mypy-protobufto dev/requirementsWhy are the changes needed?
connector/connect/dev/generate_protos.shrequires this package:Does this PR introduce any user-facing change?
No, only for contributors
How was this patch tested?
manually check