Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Fix the path in connector/connect/dev/generate_protos.sh

Why are the changes needed?

(spark_dev) ➜  dev git:(master) pwd
/Users/ruifeng.zheng/Dev/spark/connector/connect/dev
(spark_dev) ➜  dev git:(master) ./generate_protos.sh
+++ dirname ./generate_protos.sh
++ cd ./../..
++ pwd
+ SPARK_HOME=/Users/ruifeng.zheng/Dev/spark/connector
+ cd /Users/ruifeng.zheng/Dev/spark/connector
+ pushd connector/connect/src/main
./generate_protos.sh: line 22: pushd: connector/connect/src/main: No such file or directory

Does this PR introduce any user-facing change?

No

How was this patch tested?

manually check

@zhengruifeng
Copy link
Contributor Author

cc @HyukjinKwon

@HyukjinKwon HyukjinKwon changed the title [SPARK-40665][CONNECT][FOLLOWUPS] Fix connector/connect/dev/generate_protos.sh [SPARK-40665][CONNECT][FOLLOW-UP] Fix connector/connect/dev/generate_protos.sh Oct 10, 2022
@HyukjinKwon
Copy link
Member

Merged to master.

@zhengruifeng zhengruifeng deleted the connect_fix_generate_protos branch October 11, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants