Skip to content

[SPARK-40729][CORE] Make Spark use UnsafeFieldAccessor as default for Java 18+ #38190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 7 commits into from
Closed

[SPARK-40729][CORE] Make Spark use UnsafeFieldAccessor as default for Java 18+ #38190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
994f23d
fix
LuciferYang Oct 10, 2022
dccfd01
fix
LuciferYang Oct 10, 2022
ebce0f0
add to sbt
LuciferYang Oct 10, 2022
e74d457
fix comments
LuciferYang Oct 10, 2022
1da9f8b
fix scala test
LuciferYang Oct 10, 2022
ba464ee
fix sbt
LuciferYang Oct 10, 2022
1ae2874
add -Djdk.reflect.useDirectMethodHandle=false as default
LuciferYang Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion launcher/src/main/java/org/apache/spark/launcher/JavaModuleOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ public class JavaModuleOptions {
"--add-opens=java.base/sun.nio.cs=ALL-UNNAMED",
"--add-opens=java.base/sun.security.action=ALL-UNNAMED",
"--add-opens=java.base/sun.util.calendar=ALL-UNNAMED",
"--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED"};
"--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED",
"-Djdk.reflect.useDirectMethodHandle=false"};
Copy link
Contributor Author

@LuciferYang LuciferYang Oct 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to rename JavaModuleOptions as JavaExtraOptions. Do you suggest completing the corresponding refactor work in this pr? @dongjoon-hyun

Copy link
Contributor Author

@LuciferYang LuciferYang Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea is that this pr solves the issue first if need, and then do the rename work by a separate pr

Copy link
Member

@dongjoon-hyun dongjoon-hyun Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I agree with you. Let's postpone the renaming.

Copy link
Contributor Author

@LuciferYang LuciferYang Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dongjoon-hyun


/**
* Returns the default Java options related to `--add-opens' and
Expand Down
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@
--add-opens=java.base/sun.nio.cs=ALL-UNNAMED
--add-opens=java.base/sun.security.action=ALL-UNNAMED
--add-opens=java.base/sun.util.calendar=ALL-UNNAMED
-Djdk.reflect.useDirectMethodHandle=false
</extraJavaTestArgs>
</properties>
<repositories>
Expand Down
3 changes: 2 additions & 1 deletion project/SparkBuild.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,7 +1285,8 @@ object TestSettings {
"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED",
"--add-opens=java.base/sun.nio.cs=ALL-UNNAMED",
"--add-opens=java.base/sun.security.action=ALL-UNNAMED",
"--add-opens=java.base/sun.util.calendar=ALL-UNNAMED").mkString(" ")
"--add-opens=java.base/sun.util.calendar=ALL-UNNAMED",
"-Djdk.reflect.useDirectMethodHandle=false").mkString(" ")
s"-Xmx4g -Xss4m -XX:MaxMetaspaceSize=$metaspaceSize -XX:ReservedCodeCacheSize=128m -Dfile.encoding=UTF-8 $extraTestJavaArgs"
.split(" ").toSeq
},
Expand Down