Skip to content

Conversation

@LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

This pr add add dist to fileset ofmaven-clean-plugin to make mvn clean can delete the dist dir which created by dev/make-distribution.sh.

Why are the changes needed?

dev/make-distribution.sh will create a dist dir but no one cleaned it up.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Local test to confirm that dist dir can be cleaned

@github-actions github-actions bot added the BUILD label Oct 12, 2022
@LuciferYang
Copy link
Contributor Author

LuciferYang commented Oct 12, 2022

or should we add rm -rf "$DISTDIR" after line 291?

if [ "$MAKE_TGZ" == "true" ]; then
TARDIR_NAME=spark-$VERSION-bin-$NAME
TARDIR="$SPARK_HOME/$TARDIR_NAME"
rm -rf "$TARDIR"
cp -r "$DISTDIR" "$TARDIR"
tar czf "spark-$VERSION-bin-$NAME.tgz" -C "$SPARK_HOME" "$TARDIR_NAME"
rm -rf "$TARDIR"
fi

@srowen
Copy link
Member

srowen commented Oct 12, 2022

Merged to master

@srowen srowen closed this in cb53e34 Oct 12, 2022
@LuciferYang
Copy link
Contributor Author

thanks @srowen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants