[SPARK-38774][PS][FOLLOW-UP] Make parameter name in Series.autocorr consistent with Pandas
#38216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikun
approved these changes
Oct 12, 2022
Member
Yikun
left a comment
Yikun
left a comment
There was a problem hiding this comment.
LGTM, it was added in master branch (3.4.0 not released yet), safe to rename
Contributor
Author
|
Merged into master, thanks @Yikun |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
… consistent with Pandas ### What changes were proposed in this pull request? in `Series.autocorr`, rename `periods` as `lag` ### Why are the changes needed? when implementing the `Series.autocorr` in my first PS PR apache#36048 , I wrongly follow the parameter name `min_periods` in `Series.corr`, it should be `lag` to be the same with [Pandas](https://pandas.pydata.org/docs/reference/api/pandas.Series.autocorr.html) ### Does this PR introduce _any_ user-facing change? no, since 3.4 is not released ### How was this patch tested? existing UTs Closes apache#38216 from zhengruifeng/ps_ser_autocorr_rename_parameter. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
in
Series.autocorr, renameperiodsaslagWhy are the changes needed?
when implementing the
Series.autocorrin my first PS PR #36048 , I wrongly follow the parameter namemin_periodsinSeries.corr, it should belagto be the same with PandasDoes this PR introduce any user-facing change?
no, since 3.4 is not released
How was this patch tested?
existing UTs