[SPARK-40772][SQL] Improve spark.sql.adaptive.skewJoin.skewedPartitionFactor to support Double values
#38225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nFactor to support float values
dongjoon-hyun
changed the title
spark.sql.adaptive.skewJoin.skewedPartitionFactor to support float values
dongjoon-hyun
changed the title
spark.sql.adaptive.skewJoin.skewedPartitionFactor to support float valuesspark.sql.adaptive.skewJoin.skewedPartitionFactor to support double values
dongjoon-hyun
changed the title
spark.sql.adaptive.skewJoin.skewedPartitionFactor to support double valuesspark.sql.adaptive.skewJoin.skewedPartitionFactor to support Double values
Member
Author
|
Could you review this please, @viirya ? |
viirya
approved these changes
Oct 12, 2022
Member
Author
|
Thank you, @viirya . Merged to master for Apache Spark 3.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to improve
spark.sql.adaptive.skewJoin.skewedPartitionFactorto support float values by converging todoubleConffromintConf.Why are the changes needed?
Like
spark.sql.adaptive.rebalancePartitionsSmallPartitionFactor, this allows users to use the configuration more flexibly.Does this PR introduce any user-facing change?
Yes, but it will accept all previous Integer configuration values.
How was this patch tested?
Pass the CIs with the changed default value,
5.0.