[SPARK-40557][CONNECT][FOLLOW-UP] Sync python generated proto files #38244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
amaliujia
commented
Oct 14, 2022
| ) -> proto.Aggregate.AggregateFunction: | ||
| exp, fun = m | ||
| measure = proto.Aggregate.Measure() | ||
| measure = proto.Aggregate.AggregateFunction() |
Contributor
Author
There was a problem hiding this comment.
This is the only code change that is caused by the proto change. We are lacking of aggregate testing coverage thus there is no tests affected. I will follow up on the testing coverage but that is a different problem.
amaliujia
changed the title
HyukjinKwon
changed the title
Contributor
|
Merged into master |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This PR syncs python generated proto files. The proto changes in this file is generated by https://github.com/apache/spark/blob/master/connector/connect/dev/generate_protos.sh. ### Why are the changes needed? Python client side proto files are out of sync. Other python related PRs needs to re-generate proto files which has caused troubles on code review. We are looking for ways to automatically keep the python proto files in sync. Before that is done, we need to manually update the proto files. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38244 from amaliujia/sync_python_proto. Authored-by: Rui Wang <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR syncs python generated proto files. The proto changes in this file is generated by https://github.com/apache/spark/blob/master/connector/connect/dev/generate_protos.sh.
Why are the changes needed?
Python client side proto files are out of sync. Other python related PRs needs to re-generate proto files which has caused troubles on code review.
We are looking for ways to automatically keep the python proto files in sync. Before that is done, we need to manually update the proto files.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT