Skip to content

[SPARK-40788][SQL][TESTS] Check error classes in CreateNamespaceParserSuite #38246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
panbingkun wants to merge 1 commit into from
Closed

[SPARK-40788][SQL][TESTS] Check error classes in CreateNamespaceParserSuite #38246

panbingkun wants to merge 1 commit into from

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Oct 14, 2022 •
edited by MaxGekk
Loading

What changes were proposed in this pull request?

This PR aims to replace 'intercept' with 'Check error classes' in CreateNamespaceParserSuite.

Why are the changes needed?

The changes improve the error framework.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By running the modified test suite:

$ build/sbt "test:testOnly *CreateNamespaceParserSuite"

@panbingkun
Copy link
Contributor Author

panbingkun commented Oct 14, 2022

cc @MaxGekk

@github-actions github-actions bot added the SQL label Oct 14, 2022
MaxGekk
MaxGekk approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI.

@MaxGekk
Copy link
Member

MaxGekk commented Oct 14, 2022 •
edited
Loading

+1, LGTM. Merging to master.
I ran the modified tests locally:

$ build/sbt "test:testOnly *CreateNamespaceParserSuite"
[info] CreateNamespaceParserSuite:
[info] - create namespace - backward compatibility with DATABASE/DBPROPERTIES (1 second, 165 milliseconds)
[info] - create namespace - check duplicates (425 milliseconds)
[info] - create namespace - property values must be set (4 milliseconds)
[info] - create namespace - either PROPERTIES or DBPROPERTIES is allowed (4 milliseconds)
[info] - create namespace - support for other types in PROPERTIES (5 milliseconds)
...
[info] All tests passed.

Thank you, @panbingkun.

@MaxGekk MaxGekk closed this in 9d28909 Oct 14, 2022
@panbingkun panbingkun deleted the SPARK-40788 branch November 7, 2022 01:55
SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
@panbingkun @SandishKumarHN
[SPARK-40788][SQL][TESTS] Check error classes in CreateNamespaceParse…
2c11966 
…rSuite

### What changes were proposed in this pull request?
This PR aims to replace 'intercept' with 'Check error classes' in CreateNamespaceParserSuite.

### Why are the changes needed?
The changes improve the error framework.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
By running the modified test suite:
```
$ build/sbt "test:testOnly *CreateNamespaceParserSuite"
```

Closes apache#38246 from panbingkun/SPARK-40788.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGekk MaxGekk MaxGekk approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@panbingkun @MaxGekk