[SPARK-2309][MLlib] Multinomial Logistic Regression #3833

dbtsai · 2014-12-30T02:37:55Z

#1379 is automatically closed by asfgit, and github can not reopen it once it's closed, so this will be the new PR.

Binary Logistic Regression can be extended to Multinomial Logistic Regression by running K-1 independent Binary Logistic Regression models. The following formula is implemented.
http://www.slideshare.net/dbtsai/2014-0620-mlor-36132297/25

SparkQA · 2014-12-30T02:42:34Z

Test build #24878 has started for PR 3833 at commit a97b03a.

This patch merges cleanly.

SparkQA · 2014-12-30T02:48:13Z

Test build #24878 has finished for PR 3833 at commit a97b03a.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-12-30T02:48:14Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24878/
Test FAILed.

SparkQA · 2015-01-06T00:27:37Z

Test build #25072 has started for PR 3833 at commit 144a6ba.

This patch merges cleanly.

SparkQA · 2015-01-06T01:09:13Z

Test build #25072 has finished for PR 3833 at commit 144a6ba.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-01-06T01:09:16Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25072/
Test FAILed.

SparkQA · 2015-01-08T02:37:33Z

Test build #25196 has started for PR 3833 at commit 91b445d.

This patch merges cleanly.

SparkQA · 2015-01-08T03:20:30Z

Test build #25196 has finished for PR 3833 at commit 91b445d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-01-08T03:20:33Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25196/
Test FAILed.

SparkQA · 2015-01-14T07:57:37Z

Test build #25523 has started for PR 3833 at commit d12cc4f.

This patch merges cleanly.

SparkQA · 2015-01-14T08:17:34Z

Test build #25528 has started for PR 3833 at commit fc7fabe.

This patch merges cleanly.

SparkQA · 2015-01-14T08:48:41Z

Test build #25523 has finished for PR 3833 at commit d12cc4f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-01-14T08:48:44Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25523/
Test FAILed.

dbtsai · 2015-01-14T09:27:23Z

Jenkins, please re-test again.

AmplabJenkins · 2015-01-14T09:29:45Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25528/
Test FAILed.

SparkQA · 2015-01-14T09:52:38Z

Test build #25539 has started for PR 3833 at commit 06964d6.

This patch does not merge cleanly.

SparkQA · 2015-01-14T09:57:39Z

Test build #25540 has started for PR 3833 at commit 184a27e.

This patch merges cleanly.

SparkQA · 2015-01-14T11:06:11Z

Test build #25540 has finished for PR 3833 at commit 184a27e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-01-14T11:06:15Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25540/
Test PASSed.

SparkQA · 2015-01-14T11:30:27Z

Test build #25539 has finished for PR 3833 at commit 06964d6.

This patch fails PySpark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-01-14T11:30:31Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25539/
Test FAILed.

srowen · 2015-01-14T11:45:53Z

mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala

This will change this API, no? is that OK?

Also optional args are a bit Java-unfriendly. Maybe at least a helper constructor here that sets nClasses == 2

addressed. thks.

SparkQA · 2015-01-14T21:02:41Z

Test build #25565 has started for PR 3833 at commit 7ac4dfc.

This patch does not merge cleanly.

SparkQA · 2015-01-14T21:10:07Z

Test build #25565 has finished for PR 3833 at commit 7ac4dfc.

This patch fails to build.
This patch does not merge cleanly.
This patch adds no public classes.

SparkQA · 2015-02-02T08:04:39Z

Test build #26491 has finished for PR 3833 at commit 4ce4d33.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class LogisticGradient(numClasses: Int) extends Gradient
- logDebug(s"Did not load class $name from REPL class server at $uri", e)
- logError(s"Failed to check existence of class $name on REPL class server at $uri", e)

AmplabJenkins · 2015-02-02T08:04:43Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26491/
Test PASSed.

mengxr · 2015-02-02T20:17:08Z

mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala

We need to keep the original constructor to be backward compatible.

def this(weights: Vector, intercept: Double) = this(weights, intercept, weights.size, 2)

this(weights, intercept, featureSize) doesn't seem necessary to me.

mengxr · 2015-02-02T20:27:06Z

LGTM except minor inline comments. Thanks for working on the math while taking care of precision!

SparkQA · 2015-02-02T20:42:39Z

Test build #26531 has started for PR 3833 at commit 697b7c9.

This patch merges cleanly.

SparkQA · 2015-02-02T21:23:08Z

Test build #26531 has finished for PR 3833 at commit 697b7c9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-02T21:23:12Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26531/
Test FAILed.

dbtsai · 2015-02-02T21:35:50Z

Jenkins, please re-test again.

SparkQA · 2015-02-02T21:37:38Z

Test build #26543 has started for PR 3833 at commit 4e2f354.

This patch merges cleanly.

SparkQA · 2015-02-02T22:19:35Z

Test build #26543 has finished for PR 3833 at commit 4e2f354.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-02T22:19:38Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26543/
Test FAILed.

mengxr · 2015-02-02T22:32:51Z

test this please

SparkQA · 2015-02-02T22:37:53Z

Test build #26549 has started for PR 3833 at commit 4e2f354.

This patch merges cleanly.

SparkQA · 2015-02-02T23:51:09Z

Test build #26549 has finished for PR 3833 at commit 4e2f354.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- class LogisticGradient(numClasses: Int) extends Gradient

AmplabJenkins · 2015-02-02T23:51:13Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26549/
Test PASSed.

mengxr · 2015-02-03T00:01:25Z

Merged into master. Thanks for contributing MLOR! I created https://issues.apache.org/jira/browse/SPARK-5537 for the user guide and assigned to you.

### What changes were proposed in this pull request? Upgrade H2 from 2.1.214 to 2.2.220 [Changelog](https://www.h2database.com/html/changelog.html) ### Why are the changes needed? [CVE-2022-45868](https://nvd.nist.gov/vuln/detail/CVE-2022-45868) The following change in the release note fixes the CVE. [581ed18](h2database/h2database@581ed18) Merge pull request [#3833](https://github.com/h2database/h2database/issues/3833) from katzyn/password ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA Closes #41963 from bjornjorgensen/h2-2.2.220. Authored-by: Bjørn Jørgensen <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>

srowen reviewed Jan 14, 2015
View reviewed changes

mengxr reviewed Feb 2, 2015
View reviewed changes

address some feedback

697b7c9

triger jenkins

4e2f354

asfgit closed this in b1aa8fe Feb 3, 2015

dbtsai deleted the mlor branch February 26, 2015 23:35

[SPARK-2309][MLlib] Multinomial Logistic Regression #3833

[SPARK-2309][MLlib] Multinomial Logistic Regression #3833

Uh oh!

Conversation

dbtsai commented Dec 30, 2014

Uh oh!

SparkQA commented Dec 30, 2014

Uh oh!

SparkQA commented Dec 30, 2014

Uh oh!

AmplabJenkins commented Dec 30, 2014

Uh oh!

SparkQA commented Jan 6, 2015

Uh oh!

SparkQA commented Jan 6, 2015

Uh oh!

AmplabJenkins commented Jan 6, 2015

Uh oh!

SparkQA commented Jan 8, 2015

Uh oh!

SparkQA commented Jan 8, 2015

Uh oh!

AmplabJenkins commented Jan 8, 2015

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

AmplabJenkins commented Jan 14, 2015

Uh oh!

dbtsai commented Jan 14, 2015

Uh oh!

AmplabJenkins commented Jan 14, 2015

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

AmplabJenkins commented Jan 14, 2015

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

AmplabJenkins commented Jan 14, 2015

Uh oh!

srowen Jan 14, 2015

Choose a reason for hiding this comment

Uh oh!

dbtsai Jan 14, 2015

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

SparkQA commented Jan 14, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

AmplabJenkins commented Feb 2, 2015

Uh oh!

mengxr Feb 2, 2015

Choose a reason for hiding this comment

Uh oh!

mengxr commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

AmplabJenkins commented Feb 2, 2015

Uh oh!

dbtsai commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

AmplabJenkins commented Feb 2, 2015