[SPARK-40877][SQL] Reimplement crosstab with dataframe operations
#38340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Oct 22, 2022
Member
|
Merged to master. |
Contributor
Author
|
thank you @HyukjinKwon |
This was referenced Oct 24, 2022
zhengruifeng
added a commit
that referenced
this pull request
Nov 10, 2022
…tab ` ### What changes were proposed in this pull request? remove the outdated comments ### Why are the changes needed? the limitations are not true after [reimplementation](#38340) ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? doc - only Closes #38579 from zhengruifeng/doc_crosstab. Lead-authored-by: Ruifeng Zheng <[email protected]> Co-authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Reimplement `crosstab` with dataframe operations ### Why are the changes needed? 1, do not truncate the sql plan; 2, much more scalable; 3, existing implementation (added in v1.5.0) collect distinct `col1, col2` pairs to driver, while `pivot` (added in v2.4.0) only collect distinct `col2` which is much smaller; ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UTs and manually check Closes apache#38340 from zhengruifeng/sql_stat_crosstab. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…tab ` ### What changes were proposed in this pull request? remove the outdated comments ### Why are the changes needed? the limitations are not true after [reimplementation](apache#38340) ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? doc - only Closes apache#38579 from zhengruifeng/doc_crosstab. Lead-authored-by: Ruifeng Zheng <[email protected]> Co-authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reimplement
crosstabwith dataframe operationsWhy are the changes needed?
1, do not truncate the sql plan;
2, much more scalable;
3, existing implementation (added in v1.5.0) collect distinct
col1, col2pairs to driver, whilepivot(added in v2.4.0) only collect distinctcol2which is much smaller;Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs and manually check