Skip to content

[SPARK-41162][SQL] Do not push down anti-join predicates that become ambiguous #38676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EnricoMi wants to merge 4 commits into from
Closed

[SPARK-41162][SQL] Do not push down anti-join predicates that become ambiguous #38676

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08f6ea3
Do not push down join predicate that are ambiguous to both sides
EnricoMi Nov 16, 2022
7333c31
Move unit test into DataFrameJoinSuite, test LeftSemi too
EnricoMi Nov 17, 2022
d991a02
Make DeduplicateRelations considere references as well
EnricoMi Nov 18, 2022
c7eaaa2
Revert modification to PushDownLeftSemiAntiJoin rule
EnricoMi Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move unit test into DataFrameJoinSuite, test LeftSemi too
  • Loading branch information
@EnricoMi
EnricoMi committed Nov 18, 2022
commit 7333c31aba791c94fd0c169569d17a4f36718a12
18 changes: 18 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,24 @@ class DataFrameJoinSuite extends QueryTest
}
}

Seq("left_semi", "left_anti").foreach { joinType =>
test(s"SPARK-41162: $joinType self-joined aggregated dataframe") {
// aggregated dataframe
val ids = Seq(1, 2, 3).toDF("id").distinct()

// self-joined via joinType
val result = ids.withColumn("id", $"id" + 1)
.join(ids, "id", joinType).collect()

val expected = joinType match {
case "left_semi" => 2
case "left_anti" => 1
case _ => -1 // unsupported test type, test will always fail
}
assert(result.length == expected)
}
}

def extractLeftDeepInnerJoins(plan: LogicalPlan): Seq[LogicalPlan] = plan match {
case j @ Join(left, right, _: InnerLike, _, _) => right +: extractLeftDeepInnerJoins(left)
case Filter(_, child) => extractLeftDeepInnerJoins(child)
Expand Down
7 changes: 0 additions & 7 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,6 @@ class DataFrameSuite extends QueryTest
with AdaptiveSparkPlanHelper {
import testImplicits._

test("aggr antijoin") {
val ids = Seq(1, 2, 3).toDF("id").distinct()
val result = ids.withColumn("id", $"id" + 1)
.join(ids, "id", "left_anti").collect()
assert(result.length == 1)
}

test("analysis error should be eagerly reported") {
intercept[Exception] { testData.select("nonExistentName") }
intercept[Exception] {
Expand Down