Skip to content

[SPARK-42101][SQL] Make AQE support InMemoryTableScanExec #39624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulysses-you wants to merge 8 commits into from
Closed

[SPARK-42101][SQL] Make AQE support InMemoryTableScanExec #39624

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fc4749d
Make AQE support InMemoryTableScanExec
ulysses-you Mar 10, 2023
cd42dd5
address comments
ulysses-you Mar 10, 2023
295e47e
address comments
ulysses-you Mar 10, 2023
98f7da4
address comments
ulysses-you Mar 10, 2023
add320a
improve docs
ulysses-you Mar 10, 2023
4b749d8
add back shouldUpdatePlan
ulysses-you Mar 10, 2023
08e8f80
mention cache table
ulysses-you Mar 10, 2023
c9a5040
Update sql/core/src/main/scala/org/apache/spark/sql/execution/adaptiv…
ulysses-you Mar 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
  • Loading branch information
@ulysses-you
ulysses-you committed Mar 10, 2023
commit 295e47eb8fb294a64f5c138ec2d546f2db3e4d5b
18 changes: 2 additions & 16 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,22 +226,8 @@ case class AdaptiveSparkPlanExec(
}

private lazy val shouldUpdatePlan: Boolean = {
// If the `QueryExecution` does not match the current execution ID, it means the execution ID
// belongs to another (parent) query, and we should call update metrics instead of plan in
// this query. For example:
//
// ...
// |
// AdaptiveSparkPlanExec (query execution 0, no execution id)
// |
// InMemoryTableScanExec
// |
// ...
// |
// AdaptiveSparkPlanExec (query execution 1, execution id 0)
//
// We can not update plan for query execution 0 which may overwrite the whole query plan.
// Instead, we should update SQL metrics.
// Only the root `AdaptiveSparkPlanExec` of the main query that triggers this query execution
// should update UI.
Copy link
Contributor

@cloud-fan cloud-fan Mar 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// should update UI.
// need to do a final plan update for the UI.

!isSubquery && getExecutionId.exists(SQLExecution.getQueryExecution(_) eq context.qe)
}

Expand Down