Skip to content

[SQL] some comments fix for GROUPING SETS #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adrian-wang wants to merge 1 commit into from
Closed

[SQL] some comments fix for GROUPING SETS #4000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ class Analyzer(catalog: Catalog,
}

/*
* GROUP BY a, b, c, WITH ROLLUP
* GROUP BY a, b, c WITH ROLLUP
* is equivalent to
* GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (a), ( )).
* Group Count: N + 1 (N is the number of group expression)
* GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (a), ( ) ).
* Group Count: N + 1 (N is the number of group expressions)
*
* We need to get all of its subsets for the rule described above, the subset is
* represented as the bit masks.
Expand All @@ -139,12 +139,12 @@ class Analyzer(catalog: Catalog,
}

/*
* GROUP BY a, b, c, WITH CUBE
* GROUP BY a, b, c WITH CUBE
* is equivalent to
* GROUP BY a, b, c GROUPING SETS ( (a, b, c), (a, b), (b, c), (a, c), (a), (b), (c), ( ) ).
* Group Count: 2^N (N is the number of group expression)
* Group Count: 2 ^ N (N is the number of group expressions)
*
* We need to get all of its sub sets for a given GROUPBY expressions, the subset is
* We need to get all of its subsets for a given GROUPBY expression, the subsets are
* represented as the bit masks.
*/
def bitmasks(c: Cube): Seq[Int] = {
Expand Down