Skip to content

[SPARK-5201][CORE] deal with int overflow in the ParallelCollectionRDD.slice method #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
advancedxy wants to merge 7 commits into from
Closed

[SPARK-5201][CORE] deal with int overflow in the ParallelCollectionRDD.slice method #4002

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e66e60a
Deal with inclusive and exclusive ranges in one case. If the range is…
advancedxy Jan 12, 2015
196f8a8
Add test cases for ranges end with Int.MaxValue or Int.MinValue
advancedxy Jan 12, 2015
651c959
rename sign to needsInclusiveRange. add some comments
advancedxy Jan 12, 2015
7d39b9e
Convert the two cases pattern matching to one case.
advancedxy Jan 13, 2015
b3f5577
We can include the last element in the last slice in general for incl…
advancedxy Jan 14, 2015
e143d7a
Update inclusive range check for splitting inclusive range.
advancedxy Jan 14, 2015
96265a1
Update slice method comment and some responding docs.
advancedxy Jan 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
We can include the last element in the last slice in general for incl… 
…usive

range, hence eliminate the need to check Int.MaxValue or Int.MinValue.
  • Loading branch information
@advancedxy
advancedxy committed Jan 14, 2015
commit b3f55773a305d874b0a4db8258bbd8561e3c070b
6 changes: 2 additions & 4 deletions core/src/main/scala/org/apache/spark/rdd/ParallelCollectionRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,9 @@ private object ParallelCollectionRDD {
}
seq match {
case r: Range => {
// 1 to Int.MaxValue and (-2 to Int.MinValue by -1) can trigger exclusive range int overflow
val needsInclusiveRange = r.isInclusive && (r.end == Int.MaxValue || r.end == Int.MinValue)
positions(r.length, numSlices).zipWithIndex.map({ case ((start, end), index) =>
// If the range needs to be inclusive, include the last element in the last slice
if (needsInclusiveRange && index == numSlices - 1) {
// If the range is inclusive, include the last element in the last slice
if (r.isInclusive && index == numSlices - 1) {
new Range.Inclusive(r.start + start * r.step, r.end, r.step)
}
else {
Expand Down