Skip to content

[SPARK-5202] [SQL] Add hql variable substitution support #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chenghao-intel wants to merge 2 commits into from
Closed

[SPARK-5202] [SQL] Add hql variable substitution support #4003

chenghao-intel wants to merge 2 commits into from

Conversation

@chenghao-intel
Copy link
Contributor

@chenghao-intel chenghao-intel commented Jan 12, 2015

https://cwiki.apache.org/confluence/display/Hive/LanguageManual+VariableSubstitution

This is a block issue for the CLI user, it impacts the existed hql scripts from Hive.

@SparkQA
Copy link

SparkQA commented Jan 12, 2015

Test build #25405 has started for PR 4003 at commit d79af37.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 12, 2015

Test build #25405 has finished for PR 4003 at commit d79af37.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 12, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25405/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Jan 12, 2015

Test build #25407 has started for PR 4003 at commit 70c3508.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 12, 2015

Test build #25407 has finished for PR 4003 at commit 70c3508.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 12, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25407/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 14, 2015

Test build #25498 has started for PR 4003 at commit feb3822.

  • This patch merges cleanly.

@scwf
Copy link
Contributor

scwf commented Jan 14, 2015

this LGTM.

@SparkQA
Copy link

SparkQA commented Jan 14, 2015

Test build #25498 has finished for PR 4003 at commit feb3822.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 14, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25498/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25785 has started for PR 4003 at commit 1f56897.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25785 has finished for PR 4003 at commit 1f56897.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25785/
Test PASSed.

@chenghao-intel chenghao-intel mentioned this pull request Jan 20, 2015
Closed
@chenghao-intel
Copy link
Contributor Author

chenghao-intel commented Jan 21, 2015

cc @rxin @marmbrus

@marmbrus
Copy link
Contributor

marmbrus commented Jan 21, 2015

This LGTM. Please rebase.

@rxin
Copy link
Contributor

rxin commented Jan 21, 2015

This shouldn't conflict with what I'm working on, so @chenghao-intel don't worry about waiting. You can rebase now.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25934 has started for PR 4003 at commit bb41fd6.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25934 has finished for PR 4003 at commit bb41fd6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 22, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25934/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Jan 22, 2015

Thanks. Merging in master!

@asfgit asfgit closed this in 27bccc5 Jan 22, 2015
bomeng pushed a commit to Huawei-Spark/spark that referenced this pull request Jan 22, 2015
@chenghao-intel @bomeng
[SPARK-5202] [SQL] Add hql variable substitution support
a76a558 
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+VariableSubstitution

This is a block issue for the CLI user, it impacts the existed hql scripts from Hive.

Author: Cheng Hao <[email protected]>

Closes apache#4003 from chenghao-intel/substitution and squashes the following commits:

bb41fd6 [Cheng Hao] revert the removed the implicit conversion
af7c31a [Cheng Hao] add hql variable substitution support
@chenghao-intel chenghao-intel deleted the substitution branch January 22, 2015 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chenghao-intel @SparkQA @AmplabJenkins @scwf @marmbrus @rxin