Skip to content

[SPARK-42791][SQL] Create a new golden file test framework for analysis #40449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtenedor wants to merge 18 commits into from
Closed

[SPARK-42791][SQL] Create a new golden file test framework for analysis #40449

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c33f74c
commit
dtenedor Mar 15, 2023
5392f9e
commit
dtenedor Mar 15, 2023
994c9e6
clean up output
dtenedor Mar 15, 2023
e68faa6
clean up output
dtenedor Mar 15, 2023
a677845
update
dtenedor Mar 15, 2023
4efe032
commit
dtenedor Mar 15, 2023
9b908a9
commit
dtenedor Mar 15, 2023
d50b92c
respond to code review comments
dtenedor Mar 15, 2023
dd2c28e
fix compile
dtenedor Mar 16, 2023
dc994ee
fix build
dtenedor Mar 16, 2023
2009b91
respond to code review comments
dtenedor Mar 16, 2023
e0182f9
add missing file
dtenedor Mar 16, 2023
3f49ee7
respond to code review comments
dtenedor Mar 16, 2023
26e7a31
respond to code review comments
dtenedor Mar 16, 2023
87e65fd
respond to code review comments
dtenedor Mar 16, 2023
35e1bd6
respond to code review comments
dtenedor Mar 16, 2023
492069b
respond to code review comments
dtenedor Mar 18, 2023
1c8a0fa
remove unused import
dtenedor Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
respond to code review comments
  • Loading branch information
@dtenedor
dtenedor committed Mar 16, 2023
commit 35e1bd61b6e028be915e7b20b638b40e67ac9218
6 changes: 3 additions & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,13 +322,13 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession with SQLHelper
if (otherCodes.nonEmpty) {
queries ++= splitWithSemicolon(otherCodes.toSeq)
}
queries
queries.toSeq
} else {
splitWithSemicolon(allCode.toSeq).toSeq
splitWithSemicolon(allCode).toSeq
}

// List of SQL queries to run
val queries = tempQueries.map(_.trim).filter(_ != "")
val queries = tempQueries.map(_.trim).filter(_ != "").toSeq
// Fix misplacement when comment is at the end of the query.
.map(_.split("\n").filterNot(_.startsWith("--")).mkString("\n")).map(_.trim).filter(_ != "")

Expand Down