Skip to content

[SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files #40496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtenedor wants to merge 24 commits into from
Closed

[SPARK-42874][SQL] Enable new golden file test framework for analysis for all input files #40496

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c33f74c
commit
dtenedor Mar 15, 2023
5392f9e
commit
dtenedor Mar 15, 2023
994c9e6
clean up output
dtenedor Mar 15, 2023
e68faa6
clean up output
dtenedor Mar 15, 2023
a677845
update
dtenedor Mar 15, 2023
4efe032
commit
dtenedor Mar 15, 2023
9b908a9
commit
dtenedor Mar 15, 2023
d50b92c
respond to code review comments
dtenedor Mar 15, 2023
dd2c28e
fix compile
dtenedor Mar 16, 2023
dc994ee
fix build
dtenedor Mar 16, 2023
2009b91
respond to code review comments
dtenedor Mar 16, 2023
e0182f9
add missing file
dtenedor Mar 16, 2023
3f49ee7
respond to code review comments
dtenedor Mar 16, 2023
26e7a31
respond to code review comments
dtenedor Mar 16, 2023
87e65fd
respond to code review comments
dtenedor Mar 16, 2023
35e1bd6
respond to code review comments
dtenedor Mar 16, 2023
492069b
respond to code review comments
dtenedor Mar 18, 2023
bd8074c
commit
dtenedor Mar 18, 2023
1c8a0fa
remove unused import
dtenedor Mar 18, 2023
b4868f8
Merge branch 'analyzer-golden-files' into add-all-test-files
dtenedor Mar 18, 2023
7dcb503
commit
dtenedor Mar 18, 2023
d9d8abd
sync from master
dtenedor Mar 20, 2023
5d987f4
redact nondeterministic output
dtenedor Mar 20, 2023
054b8cd
redact cte reference IDs
dtenedor Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
redact cte reference IDs
  • Loading branch information
@dtenedor
dtenedor committed Mar 21, 2023
commit 054b8cdd805f6303ab723c30405730123898c332
4 changes: 2 additions & 2 deletions .../test/resources/sql-tests/analyzer-results/ansi/double-quoted-identifiers-enabled.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,14 +427,14 @@ Project [a1#x AS a2#x]
+- View (`myview`, [c1#x])
+- Project [cast(a#x as int) AS c1#x]
+- WithCTE
:- CTERelationDef 3, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias v
: +- Project [1#x AS a#x]
: +- Project [1 AS 1#x]
: +- OneRowRelation
+- Project [a#x]
+- SubqueryAlias v
+- CTERelationRef 3, true, [a#x]
+- CTERelationRef xxxx, true, [a#x]


-- !query
Expand Down
88 changes: 44 additions & 44 deletions sql/core/src/test/resources/sql-tests/analyzer-results/cte-nested.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,18 @@ WITH t as (
SELECT * FROM t
-- !query analysis
WithCTE
:- CTERelationDef 140, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t2
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 141, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [1#x]
: +- SubqueryAlias t2
: +- CTERelationRef 140, true, [1#x]
: +- CTERelationRef xxxx, true, [1#x]
+- Project [1#x]
+- SubqueryAlias t
+- CTERelationRef 141, true, [1#x]
+- CTERelationRef xxxx, true, [1#x]


-- !query
Expand All @@ -30,14 +30,14 @@ SELECT max(c) FROM (
Aggregate [max(c#x) AS max(c)#x]
+- SubqueryAlias __auto_generated_subquery_name
+- WithCTE
:- CTERelationDef 142, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [1#x AS c#x]
: +- Project [1 AS 1#x]
: +- OneRowRelation
+- Project [c#x]
+- SubqueryAlias t
+- CTERelationRef 142, true, [c#x]
+- CTERelationRef xxxx, true, [c#x]


-- !query
Expand All @@ -48,13 +48,13 @@ SELECT (
-- !query analysis
Project [scalar-subquery#x [] AS scalarsubquery()#x]
: +- WithCTE
: :- CTERelationDef 143, false
: :- CTERelationDef xxxx, false
: : +- SubqueryAlias t
: : +- Project [1 AS 1#x]
: : +- OneRowRelation
: +- Project [1#x]
: +- SubqueryAlias t
: +- CTERelationRef 143, true, [1#x]
: +- CTERelationRef xxxx, true, [1#x]
+- OneRowRelation


Expand Down Expand Up @@ -117,29 +117,29 @@ WITH
SELECT * FROM t2
-- !query analysis
WithCTE
:- CTERelationDef 145, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [1#x AS c#x]
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 147, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t2
: +- Project [scalar-subquery#x [] AS scalarsubquery()#x]
: : +- Aggregate [max(c#x) AS max(c)#x]
: : +- SubqueryAlias __auto_generated_subquery_name
: : +- WithCTE
: : :- CTERelationDef 146, false
: : :- CTERelationDef xxxx, false
: : : +- SubqueryAlias t
: : : +- Project [2#x AS c#x]
: : : +- Project [2 AS 2#x]
: : : +- OneRowRelation
: : +- Project [c#x]
: : +- SubqueryAlias t
: : +- CTERelationRef 146, true, [c#x]
: : +- CTERelationRef xxxx, true, [c#x]
: +- OneRowRelation
+- Project [scalarsubquery()#x]
+- SubqueryAlias t2
+- CTERelationRef 147, true, [scalarsubquery()#x]
+- CTERelationRef xxxx, true, [scalarsubquery()#x]


-- !query
Expand Down Expand Up @@ -173,12 +173,12 @@ SELECT max(c) FROM (
)
-- !query analysis
WithCTE
:- CTERelationDef 148, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [1#x AS c#x]
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 149, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [2#x AS c#x]
: +- Project [2 AS 2#x]
Expand All @@ -187,7 +187,7 @@ WithCTE
+- SubqueryAlias __auto_generated_subquery_name
+- Project [c#x]
+- SubqueryAlias t
+- CTERelationRef 149, true, [c#x]
+- CTERelationRef xxxx, true, [c#x]


-- !query
Expand All @@ -200,12 +200,12 @@ SELECT sum(c) FROM (
)
-- !query analysis
WithCTE
:- CTERelationDef 150, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [1#x AS c#x]
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 151, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [2#x AS c#x]
: +- Project [2 AS 2#x]
Expand All @@ -216,7 +216,7 @@ WithCTE
+- SubqueryAlias __auto_generated_subquery_name
+- Project [c#x]
+- SubqueryAlias t
+- CTERelationRef 151, true, [c#x]
+- CTERelationRef xxxx, true, [c#x]


-- !query
Expand All @@ -230,17 +230,17 @@ SELECT sum(c) FROM (
)
-- !query analysis
WithCTE
:- CTERelationDef 152, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [1#x AS c#x]
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 153, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [2#x AS c#x]
: +- Project [2 AS 2#x]
: +- OneRowRelation
:- CTERelationDef 154, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [3#x AS c#x]
: +- Project [3 AS 3#x]
Expand All @@ -251,7 +251,7 @@ WithCTE
+- SubqueryAlias __auto_generated_subquery_name
+- Project [c#x]
+- SubqueryAlias t
+- CTERelationRef 154, true, [c#x]
+- CTERelationRef xxxx, true, [c#x]


-- !query
Expand Down Expand Up @@ -338,22 +338,22 @@ WITH
SELECT * FROM t
-- !query analysis
WithCTE
:- CTERelationDef 155, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t2
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 156, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t
: +- Project [1#x]
: +- SubqueryAlias t2
: +- CTERelationRef 155, true, [1#x]
:- CTERelationDef 157, false
: +- CTERelationRef xxxx, true, [1#x]
:- CTERelationDef xxxx, false
: +- SubqueryAlias t2
: +- Project [2 AS 2#x]
: +- OneRowRelation
+- Project [1#x]
+- SubqueryAlias t
+- CTERelationRef 156, true, [1#x]
+- CTERelationRef xxxx, true, [1#x]


-- !query
Expand Down Expand Up @@ -404,23 +404,23 @@ WITH
SELECT * FROM t2
-- !query analysis
WithCTE
:- CTERelationDef 158, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t1
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 159, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias t3
: +- Project [1#x]
: +- SubqueryAlias t1
: +- CTERelationRef 158, true, [1#x]
:- CTERelationDef 160, false
: +- CTERelationRef xxxx, true, [1#x]
:- CTERelationDef xxxx, false
: +- SubqueryAlias t2
: +- Project [1#x]
: +- SubqueryAlias t3
: +- CTERelationRef 159, true, [1#x]
: +- CTERelationRef xxxx, true, [1#x]
+- Project [1#x]
+- SubqueryAlias t2
+- CTERelationRef 160, true, [1#x]
+- CTERelationRef xxxx, true, [1#x]


-- !query
Expand All @@ -435,20 +435,20 @@ SELECT * FROM (
)
-- !query analysis
WithCTE
:- CTERelationDef 161, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias cte_outer
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 162, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias cte_inner
: +- Project [1#x]
: +- SubqueryAlias cte_outer
: +- CTERelationRef 161, true, [1#x]
: +- CTERelationRef xxxx, true, [1#x]
+- Project [1#x]
+- SubqueryAlias __auto_generated_subquery_name
+- Project [1#x]
+- SubqueryAlias cte_inner
+- CTERelationRef 162, true, [1#x]
+- CTERelationRef xxxx, true, [1#x]


-- !query
Expand All @@ -468,27 +468,27 @@ SELECT * FROM (
)
-- !query analysis
WithCTE
:- CTERelationDef 163, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias cte_outer
: +- Project [1 AS 1#x]
: +- OneRowRelation
:- CTERelationDef 164, false
:- CTERelationDef xxxx, false
: +- SubqueryAlias cte_inner_inner
: +- Project [1#x]
: +- SubqueryAlias cte_outer
: +- CTERelationRef 163, true, [1#x]
:- CTERelationDef 165, false
: +- CTERelationRef xxxx, true, [1#x]
:- CTERelationDef xxxx, false
: +- SubqueryAlias cte_inner
: +- Project [1#x]
: +- SubqueryAlias __auto_generated_subquery_name
: +- Project [1#x]
: +- SubqueryAlias cte_inner_inner
: +- CTERelationRef 164, true, [1#x]
: +- CTERelationRef xxxx, true, [1#x]
+- Project [1#x]
+- SubqueryAlias __auto_generated_subquery_name
+- Project [1#x]
+- SubqueryAlias cte_inner
+- CTERelationRef 165, true, [1#x]
+- CTERelationRef xxxx, true, [1#x]


-- !query
Expand Down
Loading