Skip to content

SPARK-5270 [CORE] Elegantly check if RDD is empty #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srowen wants to merge 4 commits into from
Closed

SPARK-5270 [CORE] Elegantly check if RDD is empty #4074

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7dd04b7
Add efficient RDD.isEmpty()
srowen Jan 16, 2015
28395ff
Add isEmpty to Java, Python
srowen Jan 16, 2015
2e9b490
More tests, and Mima-exclude the new isEmpty method in JavaRDDLike
srowen Jan 18, 2015
66885b8
Add note that JavaRDDLike should not be implemented by user code
srowen Jan 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More tests, and Mima-exclude the new isEmpty method in JavaRDDLike
  • Loading branch information
@srowen
srowen committed Jan 18, 2015
commit 2e9b49061db5af9b3e040d261cb6788520d1adb9
14 changes: 14 additions & 0 deletions core/src/test/java/org/apache/spark/JavaAPISuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,20 @@ public void isEmpty() {
Assert.assertTrue(sc.emptyRDD().isEmpty());
Assert.assertTrue(sc.parallelize(new ArrayList<Integer>()).isEmpty());
Assert.assertFalse(sc.parallelize(Arrays.asList(1)).isEmpty());
Assert.assertTrue(sc.parallelize(Arrays.asList(1, 2, 3), 3).filter(
new Function<Integer,Boolean>() {
@Override
public Boolean call(Integer i) {
return i < 0;
}
}).isEmpty());
Assert.assertFalse(sc.parallelize(Arrays.asList(1, 2, 3)).filter(
new Function<Integer, Boolean>() {
@Override
public Boolean call(Integer i) {
return i > 1;
}
}).isEmpty());
}

@Test
Expand Down
2 changes: 2 additions & 0 deletions core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,8 @@ class RDDSuite extends FunSuite with SharedSparkContext {
assert(sc.emptyRDD.isEmpty())
assert(sc.parallelize(Seq[Int]()).isEmpty())
assert(!sc.parallelize(Seq(1)).isEmpty())
assert(sc.parallelize(Seq(1,2,3), 3).filter(_ < 0).isEmpty())
assert(!sc.parallelize(Seq(1,2,3), 3).filter(_ > 1).isEmpty())
}

test("sample preserves partitioner") {
Expand Down
4 changes: 4 additions & 0 deletions project/MimaExcludes.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ object MimaExcludes {
// SPARK-5166 Spark SQL API stabilization
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.Transformer.transform"),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.Estimator.fit")
) ++ Seq(
// SPARK-5270
ProblemFilters.exclude[MissingMethodProblem](
"org.apache.spark.api.java.JavaRDDLike.isEmpty")
)

case v if v.startsWith("1.2") =>
Expand Down