Skip to content

[SPARK-37829][SQL] Dataframe.joinWith outer-join should return a null value for unmatched row #40755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kings129 wants to merge 8 commits into from
Closed

[SPARK-37829][SQL] Dataframe.joinWith outer-join should return a null value for unmatched row #40755

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
58e779d
add test
kings129 Apr 11, 2023
2f43ef4
local var
kings129 Apr 11, 2023
1809a4d
add back null check in children deserializer
kings129 Apr 12, 2023
289a546
fix scala style check
kings129 Apr 12, 2023
413b632
remove extra space
kings129 Apr 14, 2023
6912c3b
use exiting nullSafe
kings129 Apr 14, 2023
2e59114
better naming
kings129 Apr 14, 2023
2372d49
keep deserializer outermost null check
kings129 Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
keep deserializer outermost null check
  • Loading branch information
@kings129
kings129 committed Apr 19, 2023
commit 2372d49b025d4cfc27c62453b51a6b1ef9cfbb87
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ object ExpressionEncoder {

new ExpressionEncoder[Any](
nullSafe(newSerializerInput, newSerializer),
newDeserializer,
nullSafe(newDeserializerInput, newDeserializer),
ClassTag(cls))
}

Expand Down