-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-4894][mllib] Added Bernoulli option to NaiveBayes model in mllib #4087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
ce73c63
added Bernoulli option to niave bayes model in mllib, added optional …
leahmcguire 4a3676d
Updated changes re-comments. Got rid of verbose populateMatrix method…
leahmcguire 0313c0c
fixed style error in NaiveBayes.scala
leahmcguire 76e5b0f
removed unnecessary sort from test
leahmcguire d9477ed
removed old inaccurate comment from test suite for mllib naive bayes
leahmcguire 3891bf2
synced with apache spark and resolved merge conflict
leahmcguire 5a4a534
fixed scala style error in NaiveBayes
leahmcguire b61b5e2
added back compatable constructor to NaiveBayesModel to fix MIMA test…
leahmcguire 3730572
modified NB model type to be more Java-friendly
jkbradley b93aaf6
Merge pull request #1 from jkbradley/nb-model-type
leahmcguire 7622b0c
added comments and fixed style as per rb
leahmcguire dc65374
integrated model type fix
leahmcguire 85f298f
Merge remote-tracking branch 'upstream/master'
leahmcguire e016569
updated test suite with model type fix
leahmcguire ea09b28
Merge remote-tracking branch 'upstream/master'
leahmcguire 900b586
fixed model call so that uses type argument
leahmcguire b85b0c9
Merge remote-tracking branch 'upstream/master'
leahmcguire c298e78
fixed scala style errors
leahmcguire 2d0c1ba
fixed typo in NaiveBayes
leahmcguire e2d925e
fixed nonserializable error that was causing naivebayes test failures
leahmcguire fb0a5c7
removed typo
leahmcguire 01baad7
made fixes from code review
leahmcguire bea62af
put back in constructor for NaiveBayes
leahmcguire 18f3219
removed private from naive bayes constructor for lambda only
leahmcguire a22d670
changed NaiveBayesModel modelType parameter back to NaiveBayes.ModelT…
leahmcguire 852a727
merged with upstream master
leahmcguire 6a8f383
Added new model save/load format 2.0 for NaiveBayesModel after modelT…
jkbradley 9ad89ca
removed old code
jkbradley 2224b15
Merge pull request #2 from jkbradley/leahmcguire-master
leahmcguire acb69af
removed enum type and replaces all modelType parameters with strings
leahmcguire f3c8994
changed checks on model type to requires
leahmcguire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixed scala style errors
- Loading branch information
commit c298e78ba7d58bb4d7e9b54d56ce51fe6b6b10a9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comma after "if 1". Period at end to separate sentences. (hard to parse otherwise)