Skip to content

SPARK-1456 Remove view bounds on Ordered in favor of a context bound on Ordering. #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marmbrus wants to merge 4 commits into from
Closed

SPARK-1456 Remove view bounds on Ordered in favor of a context bound on Ordering. #410

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35798a8
Remove view bounds on Ordered in favor of a context bound on Ordering.
marmbrus Apr 15, 2014
1b9b85c
Update scala doc.
marmbrus Apr 16, 2014
812008e
Update Java API.
marmbrus Apr 18, 2014
c574221
fix example.
marmbrus Apr 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update scala doc.
  • Loading branch information
@marmbrus
marmbrus committed Apr 16, 2014
commit 1b9b85cc76730e698e91d69cf1965a35e52b1d28
18 changes: 16 additions & 2 deletions core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,22 @@ import org.apache.spark.{Logging, RangePartitioner}
/**
* Extra functions available on RDDs of (key, value) pairs where the key is sortable through
* an implicit conversion. Import `org.apache.spark.SparkContext._` at the top of your program to
* use these functions. They will work with any key type that has a `scala.math.Ordered`
* implementation.
* use these functions. They will work with any key type `K` that has an implicit `Ordering[K]` in
* scope. Ordering objects already exist for all of the standard primitive types. Users can also
* define their own orderings for custom types, or to override the default ordering. The implicit
* ordering that is in the closest scope will be used.
*
* {{{
* import org.apache.spark.SparkContext._
*
* val rdd: RDD[(String, Int)] = ...
* implicit val caseInsensitiveOrdering = new Ordering[String] {
* override def compare(a: String, b: String) = a.toLowerCase.compare(b.toLowerCase)
* }
*
* // Sort by key, using the above case insensitive ordering.
* rdd.sortByKey
Copy link
Contributor

@rxin rxin Apr 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nit: put parenthesis around sortByKey

* }}}
*/
class OrderedRDDFunctions[K : Ordering : ClassTag,
Copy link
Contributor

@pwendell pwendell Apr 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marmbrus Do you mind updating the scaladoc above since now users can pass their own orderings in addition to an Ordered type? It might be nice to just give a one-line example of how they can define a custom ordering as well.

Copy link
Contributor Author

@marmbrus marmbrus Apr 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

V: ClassTag,
Expand Down