Skip to content

[SPARK-43376][SQL] Improve reuse subquery with table cache #41046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulysses-you wants to merge 4 commits into from
Closed

[SPARK-43376][SQL] Improve reuse subquery with table cache #41046

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54f3bc3
Improve reuse subquery with table cache
ulysses-you May 4, 2023
97ddbe7
fix
ulysses-you May 5, 2023
8a41b7a
address comment
ulysses-you May 5, 2023
99f810c
address comment
ulysses-you May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comment
  • Loading branch information
@ulysses-you
ulysses-you committed May 5, 2023
commit 8a41b7a768c37e1ebb76be4854def1bcdc5d903b
6 changes: 3 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ReuseAdaptiveSubquery.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ case class ReuseAdaptiveSubquery(

plan.transformAllExpressionsWithPruning(_.containsPattern(PLAN_EXPRESSION)) {
case sub: ExecSubqueryExpression =>
// `InsertAdaptiveSparkPlan` compiles subquery for each exprId, then the java object
// is always `eq` if two subqueries have same exprId.
// Check if the subquery can be reused manually instead of call `getOrElseUpdate`.
// The subquery can be already reused (the same Java object) due to filter pushdown
// of table cache. If it happens, we just need to wrap the current subquery with
// `ReusedSubqueryExec` and no need to update the `reuseMap`.
reuseMap.get(sub.plan.canonicalized).map { subquery =>
Copy link
Contributor

@cloud-fan cloud-fan Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that this rule is not idempotent now. If we run it twice, then all subqueries will become ReusedSubqueryExec because all subqueries are in the reuseMap.

sub.withNewPlan(ReusedSubqueryExec(subquery))
}.getOrElse {
Expand Down